feat(vmpool): Append index to ConfigMap or Secret refs #13642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This field is composed by a struct that carries options for appending a VM's index to the names of ConfigMaps or Secrets it refers to. Signed-off-by: Felix Matouschek <[email protected]>
|
Skipping CI for Draft Pull Request. |
kubevirt-bot
added
release-note
kubevirt-bot
added
area/controller
kind/api-change
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@davidvossel Can I get your opinion on this since you are the original author of that feature? |
If enabled in the VirtualMachinePoolSpec append the index of a VM to ConfigMaps and/or Secrets the VM refers to. Signed-off-by: Felix Matouschek <[email protected]>
0xFelix
force-pushed
the
vm-pool-name-generation
branch
from
475d528 to
c259673
Compare
kubevirt-bot
removed
the
do-not-merge/work-in-progress
By using label selectors in calls to List, flakes can be avoided by limiting the expected list items. Signed-off-by: Felix Matouschek <[email protected]>
0xFelix
force-pushed
the
vm-pool-name-generation
branch
from
c259673 to
d24b7fa
Compare
Add a functest to verify that VirtualMachinePools correctly append the index of a VM to ConfigMaps and/or Secrets the VM refers to. Signed-off-by: Felix Matouschek <[email protected]>
0xFelix
force-pushed
the
vm-pool-name-generation
branch
from
d24b7fa to
b4389e3
Compare
|
@vladikr Would you mind taking a look at this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Add options for appending a VM's index to the names of ConfigMaps or Secrets it refers to.
If enabled in the VirtualMachinePoolSpec append the index of a VM to ConfigMaps and/or Secrets the VM refers to.
Before adding a functional test for this feature change the functional tests to use label selectors in calls to List, to avoid flakes by limiting the expected list items.
This feature is part of the original VM pool design proposal but was never implemented.
See https://github.com/kubevirt/community/blob/c54eea11a2f42cbc7e411f8953cafdbfef257c90/design-proposals/vm-pool.md?plain=1#L52
Before this PR:
VMs in a VMPool are not able to receive individual configuration.
After this PR:
VMs in a VMPool are able to receive individual configuration.
Fixes kubevirt/user-guide#848
Why we need it and why it was done in this way
The following tradeoffs were made:
The following alternatives were considered:
Links to places where the discussion took place:
Special notes for your reviewer
Checklist
This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.
Release note