Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The source network are not selected automatically when creating an ocp to ocp plan #672

Closed
qiyuann opened this issue Aug 9, 2023 · 7 comments
Assignees
Labels
bug Categorizes issue or PR as related to a bug. ON QE QE
Milestone

Comments

@qiyuann
Copy link

qiyuann commented Aug 9, 2023

When creating an ocp to ocp plan, the source network is not selected automatically.
When there are several networks, users have to remember the network of each source VM, and select it manually. If this could be improved, it'll be more user friendly.

@yaacov yaacov added this to the 2.5.0 milestone Aug 9, 2023
@yaacov yaacov added the QE label Aug 9, 2023
@yaacov yaacov added the bug Categorizes issue or PR as related to a bug. label Aug 9, 2023
@sgratch
Copy link
Collaborator

sgratch commented Aug 10, 2023

@qiyuann I noticed that the same issue (of source network/storage selected automatically for a plan) is reproduced for the oVirt source provider as well...
Is it a known issue?

@qiyuann
Copy link
Author

qiyuann commented Aug 10, 2023

@qiyuann I noticed that the same issue (of source network/storage selected automatically for a plan) is reproduced for the oVirt source provider as well... Is it a known issue?

@sgratch On my environment, the source network/storage are selected automatically for oVirt source provider.

@sgratch
Copy link
Collaborator

sgratch commented Aug 14, 2023

@sgratch On my environment, the source network/storage are selected automatically for oVirt source provider.

Correct. It was reproduced to me when selecting an oVirt source provider with installation issues. For a valid oVirt providers, the problem is not reproduced to me as well

@sgratch
Copy link
Collaborator

sgratch commented Aug 15, 2023

Note, the solution is divided into two parts:

  1. For enabling the auto selection of the ocp network source mappings: Enable auto select for OCP source network mapping within a plan #689

  2. For enabling the auto selection of the ocp storage source mappings: this is currently blocked by OCP: add /workloads endpoint forklift#542 since there is no way to fetch the Storage Classes of the selected plan VMs disks out of the VMs yaml. Need to add a /workload endpoint for the OCP provider for fetching the list of VMs with the expanded disk info.

@yaacov yaacov added ON QE and removed ON QE labels Aug 15, 2023
@ahadas
Copy link
Member

ahadas commented Aug 16, 2023

Note, the solution is divided into two parts:

  1. For enabling the auto selection of the ocp network source mappings: Enable auto select for OCP source network mapping within a plan #689
  2. For enabling the auto selection of the ocp storage source mappings: this is currently blocked by OCP: add /workloads endpoint forklift#542 since there is no way to fetch the Storage Classes of the selected plan VMs disks out of the VMs yaml. Need to add a /workload endpoint for the OCP provider for fetching the list of VMs with the expanded disk info.

@sgratch @yaacov so how about separating out the second part to a different issue that would be resolved later on and backport the first part to 2.5.0?

@sgratch
Copy link
Collaborator

sgratch commented Aug 16, 2023

@qiyuann this issue is for the network mapping, please update the title accordingly.

I opened a follow up issue for the storage mapping: #690

@sgratch sgratch added the ON QE label Aug 16, 2023
@qiyuann qiyuann changed the title The source network/storage are not selected automatically when creating an ocp to ocp plan The source network are not selected automatically when creating an ocp to ocp plan Aug 16, 2023
@yaacov
Copy link
Member

yaacov commented Sep 6, 2023

closing all 2.5.0 issues that are none critical

cc:// @qiyuann ( feel free to reopen if needed )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Categorizes issue or PR as related to a bug. ON QE QE
Projects
None yet
Development

No branches or pull requests

4 participants