Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

K8s schema version should be read from the cluster #2

Open
f1ames opened this issue Oct 3, 2023 · 0 comments
Open

K8s schema version should be read from the cluster #2

f1ames opened this issue Oct 3, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@f1ames
Copy link
Contributor

f1ames commented Oct 3, 2023

The initial version allows to define policy with the default list of setting. One of them is k8s schemaVersion:

monokle-admission-controller/examples/policy-sample-1.yaml

Lines 19 to 21 in d959809

settings:
kubernetes-schema:
schemaVersion: v1.28.2

I think it doesn't make much sense to hardcode it like this, it should be read from the cluster by admission controller.
@f1ames f1ames added the enhancement New feature or request label Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@f1ames