Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add systems:master mention to the Authz reference page #48600

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add systems:master mention to the Authz reference page #48600

wants to merge 1 commit into from
+10 −0

Conversation

mrgiles
Copy link
Contributor

@mrgiles mrgiles commented Oct 31, 2024

Adds a paragraph describing the systems:master group to the Authorization reference page

Fixes #48546

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign sftim for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language labels Oct 31, 2024
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 31, 2024
@mrgiles mrgiles changed the title Add systems:master reference to the Authz reference page Add systems:master mention to the Authz reference page Oct 31, 2024
@netlify Netlify
Copy link

netlify bot commented Oct 31, 2024

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit cdff2b4
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/6722da07fee0e200081c2130
😎 Deploy Preview https://deploy-preview-48600--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@tengqm
Copy link
Contributor

tengqm commented Oct 31, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 31, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 2814e20ef646a5db10adde6aa441e6034ade1dd5

@mrgiles
Copy link
Contributor Author

mrgiles commented Oct 31, 2024

What do you think @sftim?

@mrgiles
Copy link
Contributor Author

mrgiles commented Nov 5, 2024

Ping PR Wrangler @salaxander for an approve label. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deads2k deads2k Awaiting requested review from deads2k

@lavalamp lavalamp Awaiting requested review from lavalamp

Assignees

@tengqm tengqm

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mention system:masters in authz page
3 participants
@mrgiles @k8s-ci-robot @tengqm