Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Persisting images across cluster resets with minikube image load #17985

Closed
KarboniteKream opened this issue Jan 18, 2024 · 13 comments
Closed

Persisting images across cluster resets with minikube image load #17985

KarboniteKream opened this issue Jan 18, 2024 · 13 comments
Labels
area/image Issues/PRs related to the minikube image subcommand lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. triage/discuss Items for discussion

Comments

@KarboniteKream
Copy link

When using minikube cache add, images are loaded into the active profile and added to config.json. With this entry, the images are loaded into the cluster during minikube start.

Currently, minikube cache add notifies the user that it's going to deprecated and that minikube image load should be used instead. However, image load does not add the entry to config.json, which means that any images loaded with this command would not be restored after minikube delete && minikube start.

Are there any plans or desire to introduce image persistence across cluster resets to image load command?

I started working on adding support for updating config.json, but I realized this approach might not be what you want for the image command, so I wanted to discuss it with you in this issue first. For example, we probably want to have separate cache for each profile.

Quick implementation to replicate cache add: https://github.com/KarboniteKream/minikube/tree/feat/image-load-persist

@spowelljr
Copy link
Member

That deprecation warning was added two years ago by someone who no longer works on the project when they added the image load command. I'm not aware of any plans for any actual deprecation, so maybe we can remove the warning? I don't know if @afbjorklund has any info on this.

@spowelljr spowelljr added the triage/discuss Items for discussion label Jan 19, 2024
@afbjorklund
Copy link
Collaborator

I think the deprecation warning is obsolete/misleading, and that the "minikube cache" and "minikube image" are using the same caching code - the main difference is if they "remember" the images for next time.

Separating the list of images per profile sounds like an interesting idea, as long as they still share the same image cache. But the list itself could be split into a global list, and a list that is kept for each profile/cluster?

@afbjorklund afbjorklund added the area/image Issues/PRs related to the minikube image subcommand label Jan 22, 2024
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 21, 2024
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle rotten
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels May 21, 2024
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue with /reopen
  • Mark this issue as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

@k8s-ci-robot k8s-ci-robot closed this as not planned Won't fix, can't repro, duplicate, stale Jun 20, 2024
@k8s-ci-robot
Copy link
Contributor

@k8s-triage-robot: Closing this issue, marking it as "Not Planned".

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue with /reopen
  • Mark this issue as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ImAARIX
Copy link

ImAARIX commented Aug 8, 2024

Any news? Will the deprecation warning disappear? Or maybe a parameter can be added to the minikube image load command to permit persistent caching?

@ImAARIX
Copy link

ImAARIX commented Aug 9, 2024

Hi @afbjorklund @spowelljr (and maybe @medyagh).
It appears that this issue was automatically closed due to inactivity, which I believe is a mistake.
The deprecation message is still there on v1.33.1, but there's no other deprecation notice or GitHub issue talking about that.

It's an important functionnality of Minikube, that offer the ability to keep images in cache after doing a minikube delete, that have no real alternatives (beside adding images tags to the $MINIKUBE_HOME/config/config.json in "cache" attribute by hand or by using minikube config set cache command, but the second one is more difficult to use).

@afbjorklund
Copy link
Collaborator

It appears that this issue was automatically closed due to inactivity, which I believe is a mistake.

The bot does that automatically, and it does not necessarily represent a decision or project direction.


I think we need some clarification on each command, and then some refactoring and clean up.

Personally I think we should keep both commands, but make the minikube image ones simpler?

@medyagh
Copy link
Member

medyagh commented Sep 18, 2024

we dont have a plan to actually stop allowing using the "cache add" however for most users I would recommend them use "image load" for local develpoment instead of cache add, cache add is meant to be across all clusters,

what we could do is change the wording of deprication to "suggested use image load for develoeprs"

@medyagh medyagh reopened this Sep 18, 2024
@medyagh
Copy link
Member

medyagh commented Sep 18, 2024

@afbjorklund I agree with you, btw how do you envision to make "image ones simpler" ?

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue with /reopen
  • Mark this issue as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

@k8s-ci-robot k8s-ci-robot closed this as not planned Won't fix, can't repro, duplicate, stale Oct 18, 2024
@k8s-ci-robot
Copy link
Contributor

@k8s-triage-robot: Closing this issue, marking it as "Not Planned".

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue with /reopen
  • Mark this issue as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/image Issues/PRs related to the minikube image subcommand lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. triage/discuss Items for discussion
Projects
None yet
Development

No branches or pull requests

7 participants