Skip to content

Commit ff046df

Browse files
committed
Update test case TestGroupConventions to fix sig-etcd as a special case
Signed-off-by: Benjamin Wang <[email protected]>
1 parent 7bbb80f commit ff046df

File tree

1 file changed

+5
-0
lines changed

1 file changed

+5
-0
lines changed

groups/groups_test.go

+5
Original file line numberDiff line numberDiff line change
@@ -168,6 +168,11 @@ func TestGroupConventions(t *testing.T) {
168168
for _, g := range cfg.Groups {
169169
// groups are easier to reason about if email and name match
170170
expectedEmailId := g.Name + "@kubernetes.io"
171+
// sig-etcd keeps using [email protected], refer to discussion in
172+
// https://github.com/kubernetes/k8s.io/pull/6542.
173+
if g.Name == "etcd-security" {
174+
expectedEmailId = "[email protected]"
175+
}
171176
if g.EmailId != expectedEmailId {
172177
t.Errorf("group '%s': expected email '%s', got '%s'", g.Name, expectedEmailId, g.EmailId)
173178
}

0 commit comments

Comments
 (0)