-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix make clean #12228
base: main
Are you sure you want to change the base?
Fix make clean #12228
Conversation
…user in docker and "-modcacherw" in go build command.
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mneverov The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This issue is currently awaiting triage. If Ingress contributors determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
✅ Deploy Preview for kubernetes-ingress-nginx canceled.
|
I think local dev/test requires |
If this is about Go cache files, the issue is not about the user, but about the file permissions. And there is a reason for them to be read-only I'd like to keep that. |
@Gacko can you post the
Can you clarify what the reason is? As I mentioned, I cloned the repo, ran |
Avoid elevating permissions to clean cache directories by using host user in docker and
-modcacherw
in go build command.Permissions were used previously but were modified in #8400 to be used for mac users only and subsequently removed in #9124.
The issue let me think that no one runs
make clean
, so another option is just to remove it.What this PR does / why we need it:
Types of changes
Which issue/s this PR fixes
fixes #12227
How Has This Been Tested?
Checklist: