-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Please correct controller and the ship correct "span->SetStatus(trace::StatusCode...." and not "Ok" as default with all http_code. #12210
Comments
This issue is currently awaiting triage. If Ingress contributors determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/assign @esigo |
is there any possibility get a "triage accepted" according this request of change some code lines ? |
for short: Here is my pull request intern in my repo on main you can do same i did per script or bash command:
|
Can you open a PR for the main project please? Thanks |
…::StatusCode...." and not "Ok" as default with all http_code. kubernetes#12210 OPENTELEMETRY_CPP_VERSION="v1.17.0" perl -pi -e "s/(OPENTELEMETRY_CPP_VERSION=)(.*)/\1\"$OPENTELEMETRY_CPP_VERSION\"/g;" images/nginx/rootfs/build.sh OPENTELEMETRY_PROTO_VERSION="v1.3.2" perl -pi -e "s/(OPENTELEMETRY_PROTO_VERSION=)(.*)/\1\"$OPENTELEMETRY_PROTO_VERSION\"/g;" images/nginx/rootfs/build.sh OPENTELEMETRY_CONTRIB_COMMIT=f6d29426ee9b4d6b476c09ca3cb9bed3cf23906f perl -pi -e "s/(OPENTELEMETRY_CONTRIB_COMMIT=)(.*)/\1\"$OPENTELEMETRY_CONTRIB_COMMIT\"/g;" images/nginx/rootfs/build.sh perl -pi -e "s/(libprotobuf.*)/\1\n abseil-cpp-crc-cpu-detect \\\/g;" images/nginx/rootfs/Dockerfile Ingress-NGINX 1.10.0 has dropped support for OpenTracing and Zipkin, favoring OpenTelemetry instead. The OpenTelemetry module used by Ingress-NGINX is based on a old commit, and has received updates since then. The correct value is not set according "span->SetStatus(trace::StatusCode::kError);". Per default it's not correct set with "span->SetStatus(trace::StatusCode::kOk);" if there a trace with error (>=http_code 500). Here is my pull request intern in my repo according: release 1.10: tsimonitoring/ingress-nginx#9 release 1.11: tsimonitoring/ingress-nginx#10 release 1.12: tsimonitoring/ingress-nginx#11 (in Datadog it's metric trace.nginx.server.errors.) The changes according Ingress-NGINX 1.11.2 with my branch solved the problem according trace error status: https://github.com/tsimonitoring/ingress-nginx/tree/release-1.11.3-patch-opentelemetry-cpp-and-contrib-and-proto As example tested on my side in Datadog. There are correct OPENTELEMETRY_CPP_VERSION, OPENTELEMETRY_PROTO_VERSION, OPENTELEMETRY_CONTRIB_COMMIT in build.sh incl. apk upgrade abseil-cpp-crc-cpu-detect (add) in Dockerfile NGINX. Before (https://i.imgur.com/LpvotMx.png) there was no shipped metric according error_status per OpenTelemetry Module. After (https://i.imgur.com/xvz6b05.png) you can see the shipped error metric also in trace view or see diag example (https://i.imgur.com/xEEY2Ep.png). Please see https://github.com/tsimonitoring/ingress-nginx/tree/release-1.11.3-patch-opentelemetry-cpp-and-contrib-and-proto Is there currently another issue associated with this? So far as i know there is no another issue associated with this (in this repo) according the "span->SetStatus(trace::StatusCode...." . Hint: There's a solved issue kubernetes#11496, which solved shipping the http error code. This issue i want to solve is: "Please correct controller and the ship correct "span->SetStatus(trace::StatusCode....". OpenTelemetry module was updated with open-telemetry/opentelemetry-cpp-contrib#443 or in detail the commit: open-telemetry/opentelemetry-cpp-contrib@415f182#diff-ac2154f3c67fc196193c979a092240e417392a11387cb1e2ba181828238cc8ffR551 .
@rikatz @esigo You ? |
Ingress-NGINX 1.10.0 has dropped support for OpenTracing and Zipkin, favoring OpenTelemetry instead.
The OpenTelemetry module used by Ingress-NGINX is based on a old commit, and has received updates since then.
The correct value is not set according "span->SetStatus(trace::StatusCode::kError);".
Per default it's not correct set with "span->SetStatus(trace::StatusCode::kOk);" if there a trace with error (>=http_code 500).
Here is my pull request intern in my repo
according:
release 1.10: tsimonitoring/ingress-nginx#9
release 1.11: tsimonitoring/ingress-nginx#10
release 1.12: tsimonitoring/ingress-nginx#11
(in Datadog it's metric trace.nginx.server.errors.)
The changes according Ingress-NGINX 1.11.2 with my branch solved the problem according trace error status: https://github.com/tsimonitoring/ingress-nginx/tree/release-1.11.3-patch-opentelemetry-cpp-and-contrib-and-proto
As example tested on my side in Datadog.
There are correct OPENTELEMETRY_CPP_VERSION, OPENTELEMETRY_PROTO_VERSION, OPENTELEMETRY_CONTRIB_COMMIT in build.sh incl. apk upgrade abseil-cpp-crc-cpu-detect (add) in Dockerfile NGINX.
Before (https://i.imgur.com/LpvotMx.png) there was no shipped metric according error_status per OpenTelemetry Module.
After (https://i.imgur.com/xvz6b05.png) you can see the shipped error metric also in trace view or see diag example (https://i.imgur.com/xEEY2Ep.png).
Please see https://github.com/tsimonitoring/ingress-nginx/tree/release-1.11.3-patch-opentelemetry-cpp-and-contrib-and-proto
Is there currently another issue associated with this?
So far as i know there is no another issue associated with this (in this repo) according the "span->SetStatus(trace::StatusCode...." .
Hint: There's a solved issue #11496, which solved shipping the http error code.
This issue i want to solve is: "Please correct controller and the ship correct "span->SetStatus(trace::StatusCode....".
OpenTelemetry module was updated with open-telemetry/opentelemetry-cpp-contrib#443
or in detail the commit:
open-telemetry/opentelemetry-cpp-contrib@415f182#diff-ac2154f3c67fc196193c979a092240e417392a11387cb1e2ba181828238cc8ffR551 .
That's why ask:
Can you please change the follow files with lines:
.
from my side i changes some lines in main git ingress-nginx path
diff --git a/images/nginx/rootfs/Dockerfile b/images/nginx/rootfs/Dockerfile
diff --git a/images/nginx/rootfs/build.sh b/images/nginx/rootfs/build.sh
This will solve the problem.
Tested in test env on my side successful.
Please see https://github.com/tsimonitoring/ingress-nginx/tree/release-1.11.3-patch-opentelemetry-cpp-and-contrib-and-proto if you want.
The text was updated successfully, but these errors were encountered: