Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature request: make node cache metrics listen port reusable #667

Open
paveew opened this issue Dec 24, 2024 · 0 comments
Open

feature request: make node cache metrics listen port reusable #667

paveew opened this issue Dec 24, 2024 · 0 comments

Comments

@paveew
Copy link

paveew commented Dec 24, 2024

Since kubernets1.25 rollouts maxSurge for DaemonSets, it's easier to support zero-downtime upgrade for node-local-dns.

If we set maxSurge to 1 and maxUnavailable to 0 for DaemonSet, a new pod will created before the old one is deleted during an upgrade, which is an expected behavior and makes node-local-dns always available.

However, the new node-local-dns pod attempts to listen port 9353 for metrics, which produces an address already in use error because the port is currently in use by the old node-local-dns pod.

If node-local-dns supports reuse of ports, i.e. SO_REUSEPORT, it would be great for this case.

node-local-dns HA reference:#324

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant