Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should APPLY requests be counted in MUTATE SLO? #8094

Open
m-messiah opened this issue Oct 2, 2024 · 0 comments
Open

Should APPLY requests be counted in MUTATE SLO? #8094

m-messiah opened this issue Oct 2, 2024 · 0 comments
Labels
sig/scalability Categorizes an issue or PR as relevant to SIG Scalability.

Comments

@m-messiah
Copy link

m-messiah commented Oct 2, 2024

The current API Call latency SLO doc does not include APPLY requests:

<a name="footnote2">\[2\]</a> By mutating API calls we mean POST, PUT, DELETE
and PATCH.

And it looks like the doc was not updated since the APPLY was introduced.

Being the main part of updates the call is definitely of MUTATE nature and seems that should not be less important than PATCH or UPDATE.

Any strong objections or side-talks why it should not be included in MUTATE group and advised for SLO?

/sig scalability
/sig docs

@k8s-ci-robot k8s-ci-robot added needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. sig/scalability Categorizes an issue or PR as relevant to SIG Scalability. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/scalability Categorizes an issue or PR as relevant to SIG Scalability.
Projects
None yet
Development

No branches or pull requests

2 participants