Add '+' to image tag pattern

[Elegant996]

What happened?

When attempting to use newTag on an image that contained a + in its tag, kustomize would not replace the tag.

What did you expect to happen?

For the image to receive the new tag.

How can we reproduce it (as minimally and precisely as possible)?

# kustomization.yaml
apiVersion: kustomize.config.k8s.io/v1beta1
kind: Kustomization
resources:
- resources.yaml

images:
- name: busybox:
  newTag: 1.37

# resources.yaml
apiVersion: v1
kind: Pod
metadata:
  name: busybox
spec:
  - name: sleeper
    image: busybox:1.37+aaaaaaaaaaaa
    command: ["/bin/sh", "-c", "trap : TERM INT; sleep infinity & wait"]

Expected output

# resources.yaml
apiVersion: v1
kind: Pod
metadata:
  name: busybox
spec:
  - name: sleeper
    image: busybox:1.37
    command: ["/bin/sh", "-c", "trap : TERM INT; sleep infinity & wait"]

Actual output

# resources.yaml
apiVersion: v1
kind: Pod
metadata:
  name: busybox
spec:
  - name: sleeper
    image: busybox:1.37+aaaaaaaaaaaa
    command: ["/bin/sh", "-c", "trap : TERM INT; sleep infinity & wait"]

Kustomize version

5.8.0

Operating system

Linux

[Elegant996]

Looks to be related to this line:

kustomize/kustomize/commands/edit/set/setimage.go

Line 24 in 311dbbf

var pattern = regexp.MustCompile(`^(.*):([a-zA-Z0-9._-]*|\*)$`)

:

[koba1t]

That is defined at the below function.

https://github.com/kubernetes-sigs/kustomize/blob/kustomize/v5.8.0/api/internal/image/image.go#L13

By the way, I think '+' in image tag is not allowed by docker image tag reference.

https://pkg.go.dev/github.com/distribution/reference#pkg-overview

Please let me know if you have a standard or definition that refers to this image tag as valid.

/triage needs-information

[koba1t]

/kind feature