Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop two ways contract for machine's failure domain #11232

Open
fabriziopandini opened this issue Sep 27, 2024 · 2 comments
Open

Drop two ways contract for machine's failure domain #11232

fabriziopandini opened this issue Sep 27, 2024 · 2 comments
Assignees
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@fabriziopandini
Copy link
Member

fabriziopandini commented Sep 27, 2024

Since 0.3.0 we are supporting a two ways contract for machine's failure domain, which is really confusing.

Most specifically, we are supporting a deprecated reverse process where InfraMachine was authoritative WRT to failure domain placement (this was implemented for allowing a transparent transition from when there was no failure domain support in Cluster API)

This issue is about creating awareness on the fact that we are going to drop the reverse process entirely with v1beta2.

I also already added an heads up warning to the infra machine contract page in #11223

Rif
https://github.com/kubernetes-sigs/cluster-api/blame/274d7e21e1ac2eb89b3f5986f6a09ff9db4eeacc/internal/controllers/machine/machine_controller_phases.go#L324-L333

/kind cleanup
/priority important-soon
/triage accepted
/help

@k8s-ci-robot
Copy link
Contributor

@fabriziopandini:
This request has been marked as needing help from a contributor.

Guidelines

Please ensure that the issue body includes answers to the following questions:

  • Why are we solving this issue?
  • To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
  • Does this issue have zero to low barrier of entry?
  • How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

What would you like to be added (User Story)?

Since 1.3.0 we are supporting a two ways contract for machine's failure domain, which is really confusing.

Most specifically, we are supporting a deprecated reverse process where InfraMachine was authoritative WRT to failure domain placement (this was implemented for allowing a transparent transition from when there was no failure domain support in Cluster API)

This issue is about creating awareness on the fact that we are going to drop the reverse process entirely with v1beta2.

I also already added an heads up warning to the infra machine contract page in #11223

Detailed Description

xx

Anything else you would like to add?

No response

Label(s) to be applied

/kind cleanup
/priority important-soon
/triage accepted
/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. triage/accepted Indicates an issue or PR is ready to be actively worked on. labels Sep 27, 2024
@hackeramitkumar
Copy link
Member

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

No branches or pull requests

3 participants