Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make leaseDurationSeconds of a lease owned by AWS Load Balancer Controller configurable #3823

Open
gjbravi opened this issue Aug 27, 2024 · 3 comments · May be fixed by #3835
Open

Make leaseDurationSeconds of a lease owned by AWS Load Balancer Controller configurable #3823

gjbravi opened this issue Aug 27, 2024 · 3 comments · May be fixed by #3835
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature.

Comments

@gjbravi
Copy link

gjbravi commented Aug 27, 2024 •
edited
Loading

Is your feature request related to a problem?
Yes, sometimes the default lease duration time of 15s of the lease aws-load-balancer-controller-leader is too high.

Describe the solution you'd like
I would like to configure the leaseDurationSeconds of a lease owned by AWS Load Balancer Controller.

Describe alternatives you've considered
Controller-runtime already provides a way of configuring LeaseTime of a Lease in here.
@shraddhabang shraddhabang added kind/feature Categorizes issue or PR as related to a new feature. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. labels Aug 28, 2024
@shraddhabang
Copy link
Collaborator

Hello @gjbravi , I agree. This would be a good feature to implement on the controller. Thank you for bringing this to our attention. I am marking this as a good-first-issue. We welcome any community contributions for such issues.

@caiofralmeida
Copy link

@gjbravi, it would be a good idea for us to contribute to the implementation, what do you think?

@gjbravi
Copy link
Author

gjbravi commented Aug 29, 2024

For sure @caiofralmeida.

@shraddhabang that's awesome, we're gonna work on that.

@gjbravi gjbravi linked a pull request Sep 3, 2024 that will close this issue
Open
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
No milestone
3 participants
@caiofralmeida @shraddhabang @gjbravi