Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make 'aws-efs-csi-driver' helm chart more configurable #1423

Open
Adityashar opened this issue Aug 1, 2024 · 1 comment
Open

Make 'aws-efs-csi-driver' helm chart more configurable #1423

Adityashar opened this issue Aug 1, 2024 · 1 comment
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@Adityashar
Copy link

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

We have a use-case where we need to scrape metrics from the following containers running in the controller deployment and node daemonset:

  1. liveness-prove
  2. csi-provisioner
  3. csi-driver-registrar

Our requirement is to add / update the arguments passed to these containers.

Describe the solution you'd like in detail
A clear and concise description of what you want to happen.

A simple helm templating block to be added in each of the containers and their values made available through the values.yaml file.

Additional context
Add any other context or screenshots about the feature request here.

The latest chart of aws-ebs-csi-driver has this implemented and can be used as a starting point. Eg https://github.com/kubernetes-sigs/aws-ebs-csi-driver/blob/master/charts/aws-ebs-csi-driver/templates/_node.tpl#L152

msmohitkumar pushed a commit to msmohitkumar/aws-efs-csi-driver that referenced this issue Oct 25, 2024
msmohitkumar added a commit to msmohitkumar/aws-efs-csi-driver that referenced this issue Oct 25, 2024
msmohitkumar pushed a commit to msmohitkumar/aws-efs-csi-driver that referenced this issue Oct 25, 2024
Make 'aws-efs-csi-driver' helm chart more configurable kubernetes-sigs#1423

Make 'aws-efs-csi-driver' helm chart more configurable kubernetes-sigs#1423
msmohitkumar pushed a commit to msmohitkumar/aws-efs-csi-driver that referenced this issue Oct 25, 2024
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Development

No branches or pull requests

3 participants