Skip to content
Permalink

Comparing changes

This is a direct comparison between two commits made in this repository or its related repositories. View the default comparison for this range or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: kubeflow/trainer
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 55ac65730a09825cadf30b787f50f16f4fb83b0d
Choose a base ref
..
head repository: kubeflow/trainer
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 9e04bdd74920cbe12ecc786010d80fb8986f27bd
Choose a head ref
Showing with 1 addition and 1 deletion.
  1. +1 −1 pkg/runtime.v2/framework/plugins/jobset/jobset.go
2 changes: 1 addition & 1 deletion pkg/runtime.v2/framework/plugins/jobset/jobset.go
Original file line number Diff line number Diff line change
@@ -116,7 +116,7 @@ func (j *JobSet) Build(ctx context.Context, info *runtime.Info, trainJob *kubefl

func needsCreateOrUpdate(old, new *jobsetv1alpha2.JobSet, trainJobIsSuspended bool) bool {
return old == nil ||
(!trainJobIsSuspended && !ptr.Equal(old.Spec.Suspend, new.Spec.Suspend)) ||
(!trainJobIsSuspended && jobSetIsSuspended(old) && !jobSetIsSuspended(new)) ||
(trainJobIsSuspended && (!equality.Semantic.DeepEqual(old.Spec, new.Spec) || !maps.Equal(old.Labels, new.Labels) || !maps.Equal(old.Annotations, new.Annotations)))
}