Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Normalize api for transform and fit_transform for embeddings #506

Open
RaczeQ opened this issue Feb 3, 2025 · 0 comments
Open

Normalize api for transform and fit_transform for embeddings #506

RaczeQ opened this issue Feb 3, 2025 · 0 comments

Comments

@RaczeQ
Copy link
Collaborator

RaczeQ commented Feb 3, 2025

CountEmbedder doesn't have fit or fit_transform function - it will be a problem to run a pipeline where we want to swap classes and reuse the same functions.

The should be a default implementation for fit and fit_transform as noop and copy of transform.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@RaczeQ