Skip to content

Commit 8a6ce26

Browse files
authored
idiomatic rust (#1485)
* idomatic rust * More idiomatic rust * make rust code more idiomatic * update
1 parent 6b2c38c commit 8a6ce26

File tree

4 files changed

+19
-30
lines changed

4 files changed

+19
-30
lines changed

codes/rust/chapter_backtracking/n_queens.rs

+4-15
Original file line numberDiff line numberDiff line change
@@ -16,11 +16,7 @@ fn backtrack(
1616
) {
1717
// 当放置完所有行时,记录解
1818
if row == n {
19-
let mut copy_state: Vec<Vec<String>> = Vec::new();
20-
for s_row in state.clone() {
21-
copy_state.push(s_row);
22-
}
23-
res.push(copy_state);
19+
res.push(state.clone());
2420
return;
2521
}
2622
// 遍历所有列
@@ -31,12 +27,12 @@ fn backtrack(
3127
// 剪枝:不允许该格子所在列、主对角线、次对角线上存在皇后
3228
if !cols[col] && !diags1[diag1] && !diags2[diag2] {
3329
// 尝试:将皇后放置在该格子
34-
state.get_mut(row).unwrap()[col] = "Q".into();
30+
state[row][col] = "Q".into();
3531
(cols[col], diags1[diag1], diags2[diag2]) = (true, true, true);
3632
// 放置下一行
3733
backtrack(row + 1, n, state, res, cols, diags1, diags2);
3834
// 回退:将该格子恢复为空位
39-
state.get_mut(row).unwrap()[col] = "#".into();
35+
state[row][col] = "#".into();
4036
(cols[col], diags1[diag1], diags2[diag2]) = (false, false, false);
4137
}
4238
}
@@ -45,14 +41,7 @@ fn backtrack(
4541
/* 求解 n 皇后 */
4642
fn n_queens(n: usize) -> Vec<Vec<Vec<String>>> {
4743
// 初始化 n*n 大小的棋盘,其中 'Q' 代表皇后,'#' 代表空位
48-
let mut state: Vec<Vec<String>> = Vec::new();
49-
for _ in 0..n {
50-
let mut row: Vec<String> = Vec::new();
51-
for _ in 0..n {
52-
row.push("#".into());
53-
}
54-
state.push(row);
55-
}
44+
let mut state: Vec<Vec<String>> = vec![vec!["#".to_string(); n]; n];
5645
let mut cols = vec![false; n]; // 记录列是否有皇后
5746
let mut diags1 = vec![false; 2 * n - 1]; // 记录主对角线上是否有皇后
5847
let mut diags2 = vec![false; 2 * n - 1]; // 记录次对角线上是否有皇后

codes/rust/chapter_backtracking/subset_sum_i.rs

+5-5
Original file line numberDiff line numberDiff line change
@@ -6,15 +6,15 @@
66

77
/* 回溯算法:子集和 I */
88
fn backtrack(
9-
mut state: Vec<i32>,
9+
state: &mut Vec<i32>,
1010
target: i32,
1111
choices: &[i32],
1212
start: usize,
1313
res: &mut Vec<Vec<i32>>,
1414
) {
1515
// 子集和等于 target 时,记录解
1616
if target == 0 {
17-
res.push(state);
17+
res.push(state.clone());
1818
return;
1919
}
2020
// 遍历所有选择
@@ -28,19 +28,19 @@ fn backtrack(
2828
// 尝试:做出选择,更新 target, start
2929
state.push(choices[i]);
3030
// 进行下一轮选择
31-
backtrack(state.clone(), target - choices[i], choices, i, res);
31+
backtrack(state, target - choices[i], choices, i, res);
3232
// 回退:撤销选择,恢复到之前的状态
3333
state.pop();
3434
}
3535
}
3636

3737
/* 求解子集和 I */
3838
fn subset_sum_i(nums: &mut [i32], target: i32) -> Vec<Vec<i32>> {
39-
let state = Vec::new(); // 状态(子集)
39+
let mut state = Vec::new(); // 状态(子集)
4040
nums.sort(); // 对 nums 进行排序
4141
let start = 0; // 遍历起始点
4242
let mut res = Vec::new(); // 结果列表(子集列表)
43-
backtrack(state, target, nums, start, &mut res);
43+
backtrack(&mut state, target, nums, start, &mut res);
4444
res
4545
}
4646

codes/rust/chapter_backtracking/subset_sum_i_naive.rs

+5-5
Original file line numberDiff line numberDiff line change
@@ -6,15 +6,15 @@
66

77
/* 回溯算法:子集和 I */
88
fn backtrack(
9-
mut state: Vec<i32>,
9+
state: &mut Vec<i32>,
1010
target: i32,
1111
total: i32,
1212
choices: &[i32],
1313
res: &mut Vec<Vec<i32>>,
1414
) {
1515
// 子集和等于 target 时,记录解
1616
if total == target {
17-
res.push(state);
17+
res.push(state.clone());
1818
return;
1919
}
2020
// 遍历所有选择
@@ -26,18 +26,18 @@ fn backtrack(
2626
// 尝试:做出选择,更新元素和 total
2727
state.push(choices[i]);
2828
// 进行下一轮选择
29-
backtrack(state.clone(), target, total + choices[i], choices, res);
29+
backtrack(state, target, total + choices[i], choices, res);
3030
// 回退:撤销选择,恢复到之前的状态
3131
state.pop();
3232
}
3333
}
3434

3535
/* 求解子集和 I(包含重复子集) */
3636
fn subset_sum_i_naive(nums: &[i32], target: i32) -> Vec<Vec<i32>> {
37-
let state = Vec::new(); // 状态(子集)
37+
let mut state = Vec::new(); // 状态(子集)
3838
let total = 0; // 子集和
3939
let mut res = Vec::new(); // 结果列表(子集列表)
40-
backtrack(state, target, total, nums, &mut res);
40+
backtrack(&mut state, target, total, nums, &mut res);
4141
res
4242
}
4343

codes/rust/chapter_backtracking/subset_sum_ii.rs

+5-5
Original file line numberDiff line numberDiff line change
@@ -6,15 +6,15 @@
66

77
/* 回溯算法:子集和 II */
88
fn backtrack(
9-
mut state: Vec<i32>,
9+
state: &mut Vec<i32>,
1010
target: i32,
1111
choices: &[i32],
1212
start: usize,
1313
res: &mut Vec<Vec<i32>>,
1414
) {
1515
// 子集和等于 target 时,记录解
1616
if target == 0 {
17-
res.push(state);
17+
res.push(state.clone());
1818
return;
1919
}
2020
// 遍历所有选择
@@ -33,19 +33,19 @@ fn backtrack(
3333
// 尝试:做出选择,更新 target, start
3434
state.push(choices[i]);
3535
// 进行下一轮选择
36-
backtrack(state.clone(), target - choices[i], choices, i, res);
36+
backtrack(state, target - choices[i], choices, i, res);
3737
// 回退:撤销选择,恢复到之前的状态
3838
state.pop();
3939
}
4040
}
4141

4242
/* 求解子集和 II */
4343
fn subset_sum_ii(nums: &mut [i32], target: i32) -> Vec<Vec<i32>> {
44-
let state = Vec::new(); // 状态(子集)
44+
let mut state = Vec::new(); // 状态(子集)
4545
nums.sort(); // 对 nums 进行排序
4646
let start = 0; // 遍历起始点
4747
let mut res = Vec::new(); // 结果列表(子集列表)
48-
backtrack(state, target, nums, start, &mut res);
48+
backtrack(&mut state, target, nums, start, &mut res);
4949
res
5050
}
5151

0 commit comments

Comments
 (0)