Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sidebar falls out of sync when hard navigating to pages outside of the current personas scope #954

Closed
ibolton336 opened this issue May 31, 2023 · 1 comment · Fixed by #1889
Closed

Sidebar falls out of sync when hard navigating to pages outside of the current personas scope #954

ibolton336 opened this issue May 31, 2023 · 1 comment · Fixed by #1889
Assignees
@rszwajko
Milestone
v0.5.0

Comments

@ibolton336
Copy link
Member

No description provided.

@ibolton336 ibolton336 moved this to Drawing Board in Konveyor UI May 31, 2023
@ibolton336 ibolton336 moved this from Drawing Board to Todo in Konveyor UI Jun 22, 2023
@dymurray dymurray moved this to 📋 Backlog in Planning Sep 15, 2023
@rszwajko rszwajko self-assigned this Apr 24, 2024
@rszwajko
Copy link
Collaborator

Steps to recreate:

  1. select "Administration" view
  2. navigate directly to a page associated with "Migration" view i.e. /controls/job-functions
  3. expected results: the sidebar shows "Migration" view as selected view (with corresponding pages)
    actual results: the sidebar for "Administration" view is show (see below)
    image

@rszwajko rszwajko mentioned this issue Apr 26, 2024
Merged
@sjd78 sjd78 moved this from 📋 Backlog to 🏗 In progress in Planning May 2, 2024
@sjd78 sjd78 added this to the v0.5.0 milestone May 7, 2024
rszwajko added a commit that referenced this issue May 9, 2024
@rszwajko
🐛 Switch sidebar type based on routes (#1889)
fa5fff2 
Linked changes:
1. fix incorrect handling of Paths.assessment and Paths.questionnaire -
both were incorrectly handled as dev routes
2. split Paths enum into type safe specialized read-only objects -
DevPaths, AdminPaths and GeneralPaths

Resolves: #954

---------

Signed-off-by: Radoslaw Szwajkowski <[email protected]>
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Planning May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rszwajko rszwajko

Labels
None yet
Projects
Planning
Status: ✅ Done
Konveyor UI
Status: Todo
Milestone
v0.5.0
Development

Successfully merging a pull request may close this issue.

🐛 Switch sidebar type based on routes rszwajko/tackle2-ui
3 participants
@sjd78 @ibolton336 @rszwajko