Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some validation error messages are not using localization (t()) #213

Open
mturley opened this issue May 12, 2022 · 1 comment
Open

Some validation error messages are not using localization (t()) #213

mturley opened this issue May 12, 2022 · 1 comment
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. needs-priority Indicates an issue or PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. tech-debt Technical debt

Comments

@mturley
Copy link
Collaborator

mturley commented May 12, 2022

This is present in most places we are using Yup's .test() method. Example:

"A business service with this name already exists. Please use a different name.",

These strings should be moved to the translation.json files and parameterized with t(). They should also not use the word "please" (see #211)

@ibolton336 ibolton336 added the tech-debt Technical debt label Jun 22, 2023
@sjd78 sjd78 added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Jul 25, 2024
@konveyor-ci-bot
Copy link

This issue is currently awaiting triage.
If contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.
The triage/accepted label can be added by org members.

@konveyor-ci-bot konveyor-ci-bot bot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates an issue or PR lacks a `priority/foo` label and requires one. labels Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. needs-priority Indicates an issue or PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. tech-debt Technical debt
Projects
None yet
Development

No branches or pull requests

3 participants