🐛 Persist filters in URL for applications table #2033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initial filter values work best if the table is not persisting state between reloads (default strategy, component state). If the table uses session or local storage then any existing filter overwrites the default value. From the end user perspective the functionality works only on first load with a clean browser (no previous state). Switching to URL filter persistence provides the same functionality and ensures we have only one source of filters. Signed-off-by: Radoslaw Szwajkowski <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2033 +/- ##
==========================================
+ Coverage 39.20% 42.15% +2.95%
==========================================
Files 146 171 +25
Lines 4857 5503 +646
Branches 1164 1305 +141
==========================================
+ Hits 1904 2320 +416
- Misses 2939 3167 +228
- Partials 14 16 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
rszwajko
added a commit
to rszwajko/tackle2-ui
that referenced
this pull request
Aug 1, 2024
Fix regression after: konveyor#1980 Resolves: https://issues.redhat.com/browse/MTA-1390 Initial filter values work best if the table is not persisting state between reloads (default strategy, component state). If the table uses session or local storage then any existing filter overwrites the default value. From the end user perspective the functionality works only on the first load with a clean browser (no previous state). Switching to URL filter persistence provides the same functionality and ensures we have only one source of filters. Reference-Url: konveyor#1698 Signed-off-by: Radoslaw Szwajkowski <[email protected]>
sjd78
pushed a commit
that referenced
this pull request
Aug 1, 2024
#2033) (#2038) Backport-of: (#2033) Fix regression after: #1980 Resolves: https://issues.redhat.com/browse/MTA-1390 Initial filter values work best if the table is not persisting state between reloads (default strategy, component state). If the table uses session or local storage then any existing filter overwrites the default value. From the end user perspective the functionality works only on the first load with a clean browser (no previous state). Switching to URL filter persistence provides the same functionality and ensures we have only one source of filters. Reference-Url: #1698 Signed-off-by: Radoslaw Szwajkowski <[email protected]>
This was referenced Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix regression after: #1980
Resolves: https://issues.redhat.com/browse/MTA-1390
Initial filter values work best if the table is not persisting state between reloads (default strategy, component state). If the table uses session or local storage then any existing filter overwrites the default value. From the end user perspective the functionality works only on the first load with a clean browser (no previous state).
Switching to URL filter persistence provides the same functionality and ensures we have only one source of filters.
Reference-Url: #1698