Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rest api return type alignment #1411

Open
2 tasks
ibolton336 opened this issue Sep 28, 2023 · 1 comment
Open
2 tasks

Rest api return type alignment #1411

ibolton336 opened this issue Sep 28, 2023 · 1 comment
Assignees
@sjd78
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. needs-priority Indicates an issue or PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. tech-debt Technical debt

Comments

@ibolton336
Copy link
Member

Currently, there are discrepancies between return types in our rest.ts file which contains the axios api handlers for external api requests. There is some deprecated usage of an old ApiClient wrapper that is no longer relevant as of the move to react query. This issues is intended to capture:

  • Work through the rest.ts file and check the function return types.
  • Ensure all queries are aligned with the return types of the api calls
@ibolton336 ibolton336 converted this from a draft issue Sep 28, 2023
@ibolton336 ibolton336 added the tech-debt Technical debt label Sep 28, 2023
@sjd78 sjd78 self-assigned this Mar 6, 2024
sjd78 added a commit to sjd78/tackle2-ui that referenced this issue Apr 5, 2024
@sjd78
🌱 Remove APIClient, update affected rest functions
da4deea 
Changes:
  - Remove `APIClient`
  - Update the affected functions in `rest.ts` to use
    axios directly
  - Double check the return types of the effected functions
  - Updated a few API model types based on current hub
    handler function responses

Resolves: konveyor#1821
Part-of: konveyor#1411

Signed-off-by: Scott J Dickerson <[email protected]>
@sjd78 sjd78 mentioned this issue Apr 5, 2024
Merged
sjd78 added a commit to sjd78/tackle2-ui that referenced this issue Apr 5, 2024
@sjd78
🌱 Remove APIClient, update affected rest functions
9d2e08b 
Changes:
  - Remove `APIClient`
  - Update the affected functions in `rest.ts` to use
    axios directly
  - Double check the return types of the effected functions
  - Updated a few API model types based on current hub
    handler function responses

Resolves: konveyor#1821
Part-of: konveyor#1411

Signed-off-by: Scott J Dickerson <[email protected]>
sjd78 added a commit to sjd78/tackle2-ui that referenced this issue Apr 9, 2024
@sjd78
🌱 Remove APIClient, update affected rest functions
af2291f 
Changes:
  - Remove `APIClient`
  - Update the affected functions in `rest.ts` to use
    axios directly
  - Double check the return types of the effected functions
  - Updated a few API model types based on current hub
    handler function responses

Resolves: konveyor#1821
Part-of: konveyor#1411

Signed-off-by: Scott J Dickerson <[email protected]>
sjd78 added a commit to sjd78/tackle2-ui that referenced this issue Apr 12, 2024
@sjd78
🌱 Remove APIClient, update affected rest functions
b83ebdf 
Changes:
  - Remove `APIClient`
  - Update the affected functions in `rest.ts` to use
    axios directly
  - Double check the return types of the effected functions
  - Updated a few API model types based on current hub
    handler function responses

Resolves: konveyor#1821
Part-of: konveyor#1411

Signed-off-by: Scott J Dickerson <[email protected]>
sjd78 added a commit to sjd78/tackle2-ui that referenced this issue Apr 16, 2024
@sjd78
🌱 Remove APIClient, update affected rest functions
58b1d3e 
Changes:
  - Remove `APIClient`
  - Update the affected functions in `rest.ts` to use
    axios directly
  - Double check the return types of the effected functions
  - Updated a few API model types based on current hub
    handler function responses

Resolves: konveyor#1821
Part-of: konveyor#1411

Signed-off-by: Scott J Dickerson <[email protected]>
sjd78 added a commit to sjd78/tackle2-ui that referenced this issue Apr 19, 2024
@sjd78
🌱 Remove APIClient, update affected rest functions
f6c3bad 
Changes:
  - Remove `APIClient`
  - Update the affected functions in `rest.ts` to use
    axios directly
  - Double check the return types of the effected functions
  - Updated a few API model types based on current hub
    handler function responses

Resolves: konveyor#1821
Part-of: konveyor#1411

Signed-off-by: Scott J Dickerson <[email protected]>
sjd78 added a commit that referenced this issue Apr 19, 2024
@sjd78
🌱 Remove APIClient, update effected rest functions (#1822)
8b13af6 
Changes:
  - Remove `APIClient`
  - Update the affected functions in `rest.ts` to use axios directly
  - Double check the return types of the effected functions
  - Updated a few API model types based on current hub handler function
    responses
  - `getApplicationSummaryCSV()` URL query param was incorrectly named and
    could lead to more results returned than expected. Query param updated
    to the correct name as per the OpenAPI definition / golang handler code.

Resolves: #1821
Part-of: #1411

---------

Signed-off-by: Scott J Dickerson <[email protected]>
@ibolton336 ibolton336 moved this from 🔖 Ready to ✅ Done in Planning Apr 29, 2024
@sjd78 sjd78 added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Jul 25, 2024
@konveyor-ci-bot konveyor-ci-bot bot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Jul 25, 2024
@konveyor-ci-bot
Copy link

This issue is currently awaiting triage.
If contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.
The triage/accepted label can be added by org members.

@konveyor-ci-bot konveyor-ci-bot bot added the needs-priority Indicates an issue or PR lacks a `priority/foo` label and requires one. label Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sjd78 sjd78

Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. needs-priority Indicates an issue or PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. tech-debt Technical debt
Projects
Planning
Status: ✅ Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sjd78 @ibolton336