From d126553f90495940f359a90ca940719a8ce93aeb Mon Sep 17 00:00:00 2001 From: "konveyor-ci-bot[bot]" <159171263+konveyor-ci-bot[bot]@users.noreply.github.com> Date: Wed, 29 May 2024 13:02:28 -0400 Subject: [PATCH] :seedling: [backport release-0.4] Add and allow test image builds for more changes (#1926) (#1927) Changes: - If any of the `package.json` files change, test the image builds. We want to make sure that changes to the `engine` or `script` blocks receive a full image build testing. - Update the npm version check to `>=9.5.0`. This will allow the test image build CI to check new builder images that also have npm major version updates. Backport-of: #1926 Signed-off-by: Scott J Dickerson Signed-off-by: Cherry Picker --- .github/workflows/ci-image-build.yml | 1 + package.json | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/ci-image-build.yml b/.github/workflows/ci-image-build.yml index de68cc8d8..6199750d9 100644 --- a/.github/workflows/ci-image-build.yml +++ b/.github/workflows/ci-image-build.yml @@ -21,6 +21,7 @@ jobs: with: files: | Dockerfile + **/package.json package-lock.json - name: Check if build related files have been changed in a PR diff --git a/package.json b/package.json index 6c0b0cba7..506881c0c 100644 --- a/package.json +++ b/package.json @@ -36,7 +36,7 @@ ], "engines": { "node": ">=18.14.2", - "npm": "^9.5.0" + "npm": ">=9.5.0" }, "devDependencies": { "@rollup/plugin-commonjs": "^25.0.7",