Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alias api json field types. #532

Open
jortel opened this issue Oct 19, 2023 · 2 comments
Open

Alias api json field types. #532

jortel opened this issue Oct 19, 2023 · 2 comments
Assignees
Labels
tech-debt This will not be worked on

Comments

@jortel
Copy link
Contributor

jortel commented Oct 19, 2023

The types defined in the model package for JSON fields should be aliased by the api package instead of being redefined (cut-n-paste). This will ensure they are consistent and that JSON fields can be migrated.

Note: This will likely cause openAPI generation issues/complexity. May not be worth it :-/

@jortel jortel added this to Planning Oct 19, 2023
@github-project-automation github-project-automation bot moved this to 🆕 New in Planning Oct 19, 2023
@jortel jortel added the tech-debt This will not be worked on label Oct 19, 2023
@jortel jortel moved this from 🆕 New to 📋 Backlog in Planning Oct 24, 2023
@jortel jortel moved this from 📋 Backlog to 🔖 Ready in Planning Oct 26, 2023
@RipulHandoo
Copy link

Hey @jortel
As i am looking forward to work on this issue.
I find myself stuck as i found the JSON type in model package like this.
However, I couldn't find any reference to this type in the api package. Could you please provide some guidance or clarification on how to handle the JSON type in the api package?
TLA!

@jortel jortel moved this from 🔖 Ready to 📋 Backlog in Planning Nov 14, 2023
@jortel jortel moved this from 📋 Backlog to 🔖 Ready in Planning Jan 23, 2024
@jortel jortel moved this from 🔖 Ready to 📋 Backlog in Planning Jan 26, 2024
@jortel
Copy link
Contributor Author

jortel commented Jan 26, 2024

Hey @RipulHandoo
The JSON type defined in the model package is not (cannot be) used and a leftover from before the migration package was introduced.
This issue has been moved back to the BACKLOG (from READY) for now. We need to put some more thought into this. As you can imagine, we're extremely cautious about changes to the model and REST resources at a core level.

@jortel jortel moved this from 📋 Backlog to 🏗 In progress in Planning Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tech-debt This will not be worked on
Projects
Status: 🏗 In progress
Development

No branches or pull requests

3 participants