Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate settings and facts keys. #213

Open
jortel opened this issue Jan 30, 2023 · 0 comments
Open

Validate settings and facts keys. #213

jortel opened this issue Jan 30, 2023 · 0 comments
Labels
kind/bug Categorizes issue or PR as related to a bug. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@jortel
Copy link
Contributor

jortel commented Jan 30, 2023 •
edited
Loading

Settings and Facts keys should not permit values with spaces or other characters that require URL encoding. This needs to be validated in the API. Perhaps a json binding directive. This is because the sub-resource API is based on the key instead of ID. Example: /settings/foobar
@jortel jortel changed the title Settings, Tags & Facts (keys) should not permit values with spaces or /. Settings and Facts keys should not permit values with spaces or /. Jan 30, 2023
@jortel jortel changed the title Settings and Facts keys should not permit values with spaces or /. Validate that Settings and Facts keys. Jan 30, 2023
@jortel jortel added the kind/bug Categorizes issue or PR as related to a bug. label Feb 2, 2023
@jortel jortel added the triage/accepted Indicates an issue or PR is ready to be actively worked on. label Mar 9, 2023
@jortel jortel moved this to Todo in Core May 13, 2023
@jortel jortel added this to Core May 13, 2023
@jortel jortel changed the title Validate that Settings and Facts keys. Validate settings and facts keys. May 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Categorizes issue or PR as related to a bug. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
Core
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jortel