Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UI] Tag spacing #148

Closed
JustinXHale opened this issue Jan 8, 2024 · 3 comments · Fixed by konveyor/tackle2-ui#1878
Closed

[UI] Tag spacing #148

JustinXHale opened this issue Jan 8, 2024 · 3 comments · Fixed by konveyor/tackle2-ui#1878
Assignees
@rszwajko
Labels
kind/design Categorizes issue or PR as related to design. priority/normal Higher priority than priority/minor. Nice to have. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Milestone
v0.4.0

Comments

@JustinXHale
Copy link
Member

JustinXHale commented Jan 8, 2024 •
edited
Loading

Problem/Solution

The spacing after a tag icon should be increased to provide space between the label and text.
PF Example https://www.patternfly.org/extensions/component-groups/tag-count/#basic-tag-count

Questions

  • Is the tag icon needed with tag in the header?
  • Does the icon add to the experience for the user?

image
@JustinXHale JustinXHale changed the title Tag spacing [UI] Tag spacing Jan 9, 2024
@JustinXHale
Copy link
Member Author

to answer my own question i think keep the tag icon

@konveyor-ci-bot konveyor-ci-bot bot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Mar 27, 2024
@konveyor-ci-bot
Copy link

This issue is currently awaiting triage.
If contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.
The triage/accepted label can be added by org members.

@konveyor-ci-bot konveyor-ci-bot bot added needs-kind Indicates an issue or PR lacks a `kind/foo` label and requires one. needs-priority Indicates an issue or PR lacks a `priority/foo` label and requires one. labels Mar 27, 2024
@github-project-automation github-project-automation bot moved this to 🆕 New in Planning Mar 27, 2024
@ibolton336 ibolton336 moved this from 🆕 New to 🔖 Ready in Planning Mar 27, 2024
@ibolton336 ibolton336 added this to the v0.4.0 milestone Mar 27, 2024
@rszwajko rszwajko mentioned this issue Apr 19, 2024
Closed
@sjd78 sjd78 added kind/design Categorizes issue or PR as related to design. priority/normal Higher priority than priority/minor. Nice to have. triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-kind Indicates an issue or PR lacks a `kind/foo` label and requires one. needs-priority Indicates an issue or PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Apr 23, 2024
@sjd78 sjd78 moved this from 🔖 Ready to 🏗 In progress in Planning Apr 23, 2024
@sjd78 sjd78 linked a pull request Apr 23, 2024 that will close this issue
✨ Extract IconWithLabel component konveyor/tackle2-ui#1878
Merged
@sjd78 sjd78 moved this from 🏗 In progress to ✅ Done in Planning Apr 25, 2024
@sjd78
Copy link
Member

sjd78 commented May 9, 2024

Implemented with konveyor/tackle2-ui#1878

@sjd78 sjd78 closed this as completed May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rszwajko rszwajko

Labels
kind/design Categorizes issue or PR as related to design. priority/normal Higher priority than priority/minor. Nice to have. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
Planning
Status: ✅ Done
Milestone
v0.4.0
Development

Successfully merging a pull request may close this issue.

✨ Extract IconWithLabel component rszwajko/tackle2-ui
4 participants
@sjd78 @ibolton336 @rszwajko @JustinXHale