Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vscode/editor] in editor view of specific proposed changes #70

Open
djzager opened this issue Oct 17, 2024 · 3 comments
Open

[vscode/editor] in editor view of specific proposed changes #70

djzager opened this issue Oct 17, 2024 · 3 comments
Assignees
Milestone

Comments

@djzager
Copy link
Member

djzager commented Oct 17, 2024

When we are presenting the user with the response we got from the kai/rpc-server, one thing that would be really helpful is if the user could gain additional context on the proposed change by, clicking the filename for the codeblock or clicking the codeblock itself, opening that file in the editor where the proposed change is to be made. Additionally, we may elect to show the change in the editor with the option to accept/reject.

@djzager
Copy link
Member Author

djzager commented Oct 29, 2024

Now that we have removed #69 from the minimum demoable thing, the scope of this effort has increased along with #67 , specifically this comment #67 (comment).

The important notes about how this effort has changed:

  1. The webview will message the diff viewer with the proposed solution after kai/rpc-server has responded to our solution request and we have performed any necessary post processing.
  2. The webview will be "disabled", preventing user input while the user works through the proposed solution.
  3. The diff-viewer must notify the webview when the user has "finished" reconciling the proposed solution.

@dymurray dymurray added this to the Milestone #2 milestone Oct 31, 2024
@dymurray dymurray moved this to In Progress in Kai Tech Preview Release Oct 31, 2024
@rszwajko
Copy link
Contributor

Most of the scope implemented in #79
The missing part is implementing the accept/reject buttons in the editor itself (i.e. code lense style). Right now it's implemented in the Konveyor Resolution view (native VS Code tree view).

@rszwajko
Copy link
Contributor

Missing parts implemented in #102

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

No branches or pull requests

3 participants