Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client protected methods should be refactored out into separate specable classes #18

Open
SpComb opened this issue Jul 31, 2017 · 0 comments

Comments

@SpComb
Copy link
Contributor

SpComb commented Jul 31, 2017

The Kontena::Websocket::Client class contains many methods that are intended to be private, but this is currently commented to allow the client specs to call those methods.

Most of those methods are related to the actual TCP/SSL-level client behavior, and refactoring those out into separate TCP/SSL client classes would allow specs to be written for those APIs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant