Skip to content
This repository has been archived by the owner on Sep 18, 2024. It is now read-only.

P0009 : Address 2017-11 LEWG feedback to advance to LWG #48

Open
hcedwar opened this issue Feb 8, 2018 · 6 comments
Open

P0009 : Address 2017-11 LEWG feedback to advance to LWG #48

hcedwar opened this issue Feb 8, 2018 · 6 comments
Assignees

Comments

@hcedwar
Copy link
Contributor

hcedwar commented Feb 8, 2018

Address 2017-11 LEWG feedback to advance to LWG.

@hcedwar hcedwar self-assigned this Feb 8, 2018
@dsunder
Copy link
Contributor

dsunder commented Feb 9, 2018

  • nullptr constructor removed
  • constexpr added to operator()( ... )
  • fixed example typos
  • moved examples to appendix
  • Changed note in 3.2.2 to a see appendix
    @hcedwar I changed note to see_below, but not sure if it is in the exact form they want, please review

TODO

@hcedwar small group requested that the oral explanation that you and Christian gave in section 3.5.2 about "layout mapping of indices ... to codomain" be specified in detail

Small group requested ability to index by template arguments, but large group showed no interest,
should we mention that in the Appendix?

@dhollman
Copy link
Contributor

@dsunder why did we remove the nullptr constructor again? Don’t we want this to be a nullable type?

@hcedwar
Copy link
Contributor Author

hcedwar commented Feb 11, 2018 via email

@dhollman
Copy link
Contributor

dhollman commented Feb 12, 2018

That was feedback on span, and it was pretty controversial. I don't think span intends to remove the nullptr constructor. I think it was made by someone who wasn't familiar with the importance of a nullptr constructor (their comment was "why not use the default constructor" and there's a really good reason for that: implicit convertibility from nullptr). I went through this in #46

@hcedwar
Copy link
Contributor Author

hcedwar commented Feb 12, 2018

From LEWG notes (included in #46): Poll to remove nullptr_t constructor: 4-5-3-0-0

@dhollman
Copy link
Contributor

I guess I was mixing it up with other discussion; sorry.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants