Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Help document bug] For gifsicle, the help document misses some options #187

Open
ccccmd opened this issue Dec 30, 2022 · 0 comments
Open

Comments

@ccccmd
Copy link

ccccmd commented Dec 30, 2022

The "--help" option of gifsicle misses some options "gray", "ignore-errors", "nextfile", "resize-geometry" for version 1.93.

For the option "gray", the following code appears during option parsing and calls the MARK_CH, Gif_DeleteColormap, set_new_fixed_colormap in src/gifsicle.c:1930-1932 for version 1.93.

      MARK_CH(output, CH_USE_COLORMAP);
      Gif_DeleteColormap(def_output_data.colormap_fixed);
      set_new_fixed_colormap("gray");

For the option "ignore-errors", the following code appears during option parsing and modifies the no_ignore_errors in src/gifsicle.c:2096 for version 1.93.

      no_ignore_errors = clp->negated;

For the option "nextfile", the following code appears during option parsing and modifies the gif_read_flags, nextfile in src/gifsicle.c:2114-2119 for version 1.93.

      if (clp->negated)
        gif_read_flags &= ~GIF_READ_TRAILING_GARBAGE_OK;
      else {
        gif_read_flags |= GIF_READ_TRAILING_GARBAGE_OK;
        nextfile = 1;
      }

For the option "resize-geometry", the following code appears during option parsing and calls the MARK_CH, parse_resize_geometry_opt and modifies the def_output_data.scaling in src/gifsicle.c:2057-2062 for version 1.93.

      MARK_CH(output, CH_RESIZE);
      if (clp->negated)
        def_output_data.scaling = GT_SCALING_NONE;
      else
        parse_resize_geometry_opt(&def_output_data, clp->val.s, clp);
      break;

But it does not appear in the document provided by "--help".

It may prevent users from using the relevant function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant