Remove attachment files from storage on Instance objects deletion

onadata/apps/logger/__init__.py

@@ -1 +1,13 @@
 # coding: utf-8
+from django.apps import AppConfig
+
+
+class LoggerAppConfig(AppConfig):
+
+    name = 'onadata.apps.logger'
+
+    def ready(self):
+        # Makes sure all signal handlers are connected
+        # Uncomment the lines below if you need signals
+        from onadata.apps.logger import signals
+        super().ready()

onadata/apps/logger/signals.py

@@ -0,0 +1,19 @@
+# coding: utf-8
+import logging
+from django.db.models.signals import pre_delete
+from django.dispatch import receiver
+
+from onadata.apps.logger.models.attachment import Attachment
+
+
+@receiver(pre_delete, sender=Attachment)
+def post_delete_asset(instance, **kwargs):
+    # Unfortunately, it seems that Django does not call Model.delete() on
+    # delete CASCADE. But this signal is called though.
+    # We want to delete all files when an Instance (or Attachment) object is
+    # deleted.
+    try:
+        instance.media_file.delete()
+    except Exception as e:
+        logger = logging.getLogger('console_logger')
+        logger.error(str(e), exc_info=True)

onadata/apps/logger/xform_instance_parser.py

@@ -332,7 +332,6 @@ def _set_attributes(self):
                 logger = logging.getLogger("console_logger")
                 logger.debug("Skipping duplicate attribute: %s"
                              " with value %s" % (key, value))
-                logger.debug(str(all_attributes))
             else:
                 self._attributes[key] = value
 

onadata/libs/utils/logger_tools.py

@@ -4,6 +4,7 @@
 import sys
 import traceback
 from datetime import date, datetime
+from xml.etree import ElementTree as ET
 from xml.parsers.expat import ExpatError
 
 import pytz
@@ -53,7 +54,8 @@
     clean_and_parse_xml,
     get_uuid_from_xml,
     get_deprecated_uuid_from_xml,
-    get_submission_date_from_xml)
+    get_submission_date_from_xml,
+)
 from onadata.apps.main.models import UserProfile
 from onadata.apps.viewer.models.data_dictionary import DataDictionary
 from onadata.apps.viewer.models.parsed_instance import ParsedInstance

onadata/settings/base.py

@@ -211,7 +211,7 @@ def skip_suspicious_operations(record):
     'rest_framework.authtoken',
     'taggit',
     'readonly',
-    'onadata.apps.logger',
+    'onadata.apps.logger.LoggerAppConfig',
     'onadata.apps.viewer',
     'onadata.apps.main',
     'onadata.apps.restservice',