Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat:(format): add pickle format #183

Merged
merged 1 commit into from
Jul 21, 2021
Merged

feat:(format): add pickle format #183

merged 1 commit into from
Jul 21, 2021

Conversation

gbolmier
Copy link
Contributor

What type of PR is this?

/kind feature
/area model

What this PR does / why we need it:

Adds support for pickle format, the de facto Python object serialization protocol, used by many data scientists to serialize their ML models/artifacts.

Which issue(s) this PR is related to (optional, link to 3rd issue(s)):

Closes #182

Does this PR introduce a user-facing change?:

NONE

@caicloud-bot caicloud-bot added release-note-none Denotes a PR that doesn't merit a release note. kind/feature Categorizes issue or PR as related to a new feature. area/model Model related functions, including model warehouse, model compression, model evaluation, etc. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 21, 2021
gaocegege
gaocegege approved these changes Jul 21, 2021
View reviewed changes
Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
Thanks for your contribution! 🎉 👍

@caicloud-bot caicloud-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 21, 2021
@caicloud-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaocegege

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@caicloud-bot caicloud-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 21, 2021
@caicloud-bot caicloud-bot merged commit 429b392 into kleveross:master Jul 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaocegege gaocegege gaocegege approved these changes

Assignees

@gaocegege gaocegege

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/model Model related functions, including model warehouse, model compression, model evaluation, etc. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[feature] Add support for pickle format
3 participants
@gbolmier @caicloud-bot @gaocegege