Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cmd): impl ormb models command #172

Merged
merged 2 commits into from
Jan 26, 2021
Merged

feat(cmd): impl ormb models command #172

merged 2 commits into from
Jan 26, 2021

Conversation

simon-cj
Copy link
Contributor

What type of PR is this?
/kind feature

What this PR does / why we need it:
impl ormb models command as follow:

$ ./bin/ormb models
REPOSITORY                                     TAG                         MODEL ID     CREATED              SIZE   
x/release/a                                    b                           d69852fea834 30 minutes ago       28.9MB 
harbor-harbor-core.clever-system/detect/detect sm3                         6d0847e5ed11 4 days ago           162.1KB
x/release/a                                    bxxxxxxxxxxxxxaaaaaaaaaaaaa d69852fea834 30 minutes ago       28.9MB

Which issue(s) this PR is related to (optional, link to 3rd issue(s)):

Fixes #169

Reference to #

Special notes for your reviewer:

/cc @FogDong

Does this PR introduce a user-facing change?:

feat(cmd): impl ormb models command

@caicloud-bot caicloud-bot requested a review from FogDong January 25, 2021 08:21
@caicloud-bot caicloud-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 25, 2021
@simon-cj simon-cj force-pushed the fix-format branch 4 times, most recently from 4522543 to 1c1eefe Compare January 25, 2021 08:28
@caicloud-bot caicloud-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 25, 2021
FogDong
FogDong reviewed Jan 26, 2021
View reviewed changes
pkg/oras/client.go Outdated
for _, ref := range refs {
timeDiff := time.Now().Sub(ref.CreatedAt)
timeShow := ""
if timeDiff.Hours()/(365*24.0*7) > 1.0 {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can find some third package to do the time format

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think so, but I am not found, have any suggestion?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

FogDong
FogDong reviewed Jan 26, 2021
View reviewed changes
Copy link
Member

@FogDong FogDong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@caicloud-bot caicloud-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 26, 2021
@caicloud-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FogDong

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@caicloud-bot caicloud-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 26, 2021
@caicloud-bot caicloud-bot merged commit d35e13c into kleveross:master Jan 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FogDong FogDong FogDong left review comments

Assignees

@FogDong FogDong

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[feature] impl ormb models command
3 participants
@simon-cj @caicloud-bot @FogDong