Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Do not require sub-directory in model if the format does not need it. #118

Closed
gaocegege opened this issue Aug 26, 2020 · 1 comment · Fixed by #120
Closed

[feature] Do not require sub-directory in model if the format does not need it. #118

gaocegege opened this issue Aug 26, 2020 · 1 comment · Fixed by #120

Comments

@gaocegege
Copy link
Member

Is this a BUG REPORT or FEATURE REQUEST?:

Uncomment only one, leave it on its own line:

/kind bug
/kind feature

What happened:

TensorFlow savedmodel has a sub-directory in the model directory like this:

- model
  - 1
    - saved_model.pb
    ...

But other formats does not need it, we should not require it in other frameworks.

As you know, TRTIS requires it, too. We can make this directory in storage initializer.

What you expected to happen:

How to reproduce it (as minimally and precisely as possible):

Anything else we need to know?:

@simon-cj
Copy link
Contributor

if so, the PR 33b44e7 is not right, should keep it same as before?I misunderstanding?
accourding to this issue, including TensorFlow Savedmodel,there should not have 1 directory.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants