Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add expander signal #1283

Open
Aphexus opened this issue Oct 23, 2024 · 1 comment
Open

Add expander signal #1283

Aphexus opened this issue Oct 23, 2024 · 1 comment
Labels
upstream Issues that need to be dealt with at scraper level or some other repo

Comments

@Aphexus
Copy link

Aphexus commented Oct 23, 2024

In Kiwix JS and the wikipedia zim when clicking on a section (such as Examples) it hides the content but there is no way of knowing it does this or not since everything looks the same. [One might be able to tell that the next line is that of a new section but it is not so obvious]

E.g., having a simple expander indication like a down arrow or when unexpanded some text that says "expand" would be helpful.

@kelson42 kelson42 transferred this issue from kiwix/kiwix-android Oct 28, 2024
@Jaifroid
Copy link
Member

Jaifroid commented Oct 29, 2024

Thank you for this report @Aphexus. I think currently the opening and closing of sections is in transition, and is no longer supported in the newest ZIMs scraped with the dev version of mwOffliner. In reality, I think this issue belongs to mwOffliner, because we don't do anything in Kiwix JS to add code that is not already in the ZIM, so this would only be fixable upstream, not here. However, I'm not sure it's worth transferring this issue to mwOffliner because a recent issue there about headings no longer being closeable was concluded with the fact that this functionality will no longer be supported going forward.

It strikes me that you might be using the PWA version of Kiwix JS, rather than the Browser Extension version (this Repo). However, even there, we depend on upstream support for the feature, and although we tried to emulate it in Restricted mode (former "jQuery mode"), we need to await finalization of the ZIM format for ZIMs scraped from the mobile-html endpoint to decide what to do about this functionality. If it is no longer supported anywhere in Kiwix, it may be best just to remove it.

EDIT: I'll leave this open until we have certainty upstream.

@Jaifroid Jaifroid added the upstream Issues that need to be dealt with at scraper level or some other repo label Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
upstream Issues that need to be dealt with at scraper level or some other repo
Projects
None yet
Development

No branches or pull requests

2 participants