Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iPad video subtitles pop-over is really small #915

Open
BPerlakiH opened this issue Aug 5, 2024 · 15 comments
Open

iPad video subtitles pop-over is really small #915

BPerlakiH opened this issue Aug 5, 2024 · 15 comments
Assignees
Milestone

Comments

@BPerlakiH
Copy link
Collaborator

The subtitles pop-over is really small (compared to the native one, which is disabled by video js).

@BPerlakiH BPerlakiH self-assigned this Aug 5, 2024
@kelson42 kelson42 added this to the 3.5.0 milestone Aug 5, 2024
@BPerlakiH
Copy link
Collaborator Author

So far the only way I have found is to adjust videojs settings in the content itself, which requires some find a replace magic on the loaded HTML content, which might or might not work...

I think we can leave this issue as is, the user can switch between subtitle languages more easily in full screen mode, only the inline one is really small.

See here:

Screenshot 2024-08-09 at 11 03 55

compared to the full screen one:
Screenshot 2024-08-09 at 11 00 28

@kelson42
Copy link
Contributor

kelson42 commented Aug 11, 2024

@BPerlakiH The bug report lack of details. You mean you would like to have the popup box to have a bigger maximum height? What do you mean with native one? Could we have clear screenshots of what you get against what you expect?
@benoit74 Would that be some we could and should do in the ZIM? Report upstream to video.js?

@BPerlakiH
Copy link
Collaborator Author

@kelson42 here is the comparison between using the provided videojs ui on the iPad,
and how it looks when we turn videojs off, and the native/system ui is used:

videojs:

videojs_ui.mp4

native:

native_ui.mp4

@BPerlakiH
Copy link
Collaborator Author

BPerlakiH commented Aug 13, 2024

So to sum up, this is specific only to iPad, and only when the video is not in full screen, it is really hard to browse those languages, and you need to be really accurate selecting, as it's less than half of a finger size.

If the video is in full screen the subtitles can be changed without any problems.
Probably it's a small issue, and might be fixed in next video js releases.
(the new video ZIM provided in: #914 unfortunately has no subtitles, so couldn't use that for this purpose).

@kelson42 kelson42 modified the milestones: 3.5.0, 3.6.0 Aug 16, 2024
@kelson42 kelson42 removed the question label Aug 16, 2024
@kelson42
Copy link
Contributor

@benoit74 Your feedback would be welcome here about (1) "issue" assessment (2) how the solution could/should look like.

@benoit74
Copy link

If I get the issue correctly, then I think that this should be reported to videoJS since a generic solution would help all users.

I don't have an iPad to test, but do we have the same issue on https://videojs.com/advanced?video=bipbop-advanced?

@benoit74
Copy link

And don't we have the same issue on all small touch screens? (e.g. on my Android phone, it is not easy to be sure to spot proper language either)

@kelson42
Copy link
Contributor

@benoit74 Probably! To me this is an enhancement to do at videojs level and if they can't using a custom CSS to apply in our scraper(s). Therefore I would propose to:

  • Move to openzim/youtube
  • Open an issue upstream

Does that sounds appropriate?

@benoit74
Copy link

Why youtube ? video.js is used in many scrapers, not only youtube.

@kelson42 kelson42 assigned benoit74 and unassigned benoit74 Sep 19, 2024
@kelson42
Copy link
Contributor

Why youtube ? video.js is used in many scrapers, not only youtube.

Once fixed in youtube scraper I will request to fix in other scrapers. One issue at a time.

@benoit74
Copy link

But this issue speaks about a problem in TED ...

@kelson42
Copy link
Contributor

@benoit74 Oui, so move to openzim/ted. Does that change anything at the end (i believe all our scrapers are impacted in the manner, or isn't it the case)?

@benoit74
Copy link

All scrapers relying on video.js are probably impacted in the same manner indeed

@kelson42 kelson42 assigned benoit74 and unassigned BPerlakiH Oct 10, 2024
@kelson42
Copy link
Contributor

Assigning to @benoit74 as this is something which might be improved at scraper level. Moving to next milestone.

@kelson42 kelson42 modified the milestones: 3.6.0, 3.7.0 Oct 10, 2024
@benoit74
Copy link

I have opened videojs/video.js#8892 to start the discussion at video.js side.

That been said, I don't get why once in fullscreen you have a kind of different player. I don't have the same behavior on Android in my browser or in the app. Is this something specific to kiwix-apple?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants