Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List of categories seems to be static #1023

Open
benoit74 opened this issue Nov 4, 2024 · 1 comment
Open

List of categories seems to be static #1023

benoit74 opened this issue Nov 4, 2024 · 1 comment

Comments

@benoit74
Copy link

benoit74 commented Nov 4, 2024

The list of categories seems to be static, e.g. it misses at least phet, video, iFixit, ... and blank category (more a library problem, but we need to be able to search these ZIMs as well).

Image

Do we want to make this list of categories dynamic or should we simply update the list before each release?

Updating the list before each release allows to continue to transform the OPDS category (e.g. stack_exchange) into a nice looking label (e.g. StackExchange).

Making the list dynamic allows to not care about updating it and being very reactive to library changes. It more or less forces us to stop transforming OPDS category into nice looking label.

But this transformation of OPDS category is anyway a bad idea from my PoV, we should represent the category as is stored in the OPDS catalog, and AFAIK nothing forces us to have ugly technical categories in the catalog / ZIM (this needs to be answered / solved in kiwix/overview#104).

From my PoV, making the list dynamic is in fact mostly mandatory because we have old devices in the wild, stuck on old iOS versions and hence stuck on old Kiwix app versions. If the list is not dynamic, it means the app will never update its categories ... which is really bad.

@kelson42
Copy link
Contributor

kelson42 commented Nov 4, 2024

Do we want to make this list of categories dynamic or should we simply update the list before each release?

Should be (mostly) dynamic, via https://kiwix-tools.readthedocs.io/en/latest/kiwix-serve.html#catalog-v2-categories. But we can rely on libkiwix or/and cache if offline.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants