Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release tag seems wrong #971

Open
kelson42 opened this issue Sep 8, 2024 · 3 comments · May be fixed by #1010
Open

Release tag seems wrong #971

kelson42 opened this issue Sep 8, 2024 · 3 comments · May be fixed by #1010
Assignees
Milestone

Comments

@kelson42
Copy link
Contributor

kelson42 commented Sep 8, 2024

For some reason it is testflight-3.5.2 and it should be 3.5.2

Unclear - at least right now - to me why we don't have a proper tag.

@kelson42 kelson42 added this to the 3.6.0 milestone Sep 8, 2024
@BPerlakiH
Copy link
Collaborator

BPerlakiH commented Sep 8, 2024

It seems to me that we are re-using the tags that were used to created the TestFlight releases (and which was approved by Apple), and we do not create a new tag.
In other words we do want to re-create the very same macOS build for FTP, as part of the GitHub release process, so we pointing it to the (Apple approved) TestFlight tag.
(In case of a TestFlight build, the trigger is the appropriate tag. In case of the release, the trigger is the release itself.)

@kelson42
Copy link
Contributor Author

kelson42 commented Sep 18, 2024

To me the workflow should be as such:

  • Tag testflight when you want to do Testflight release. If this tag already exists, then removes/superseeds older version.
  • If we make a release, then tag x.y.z and release in GitHub.
  • Releasing a version triggers the publishing to testflight but only such a version should make it through production.
  • If there is a problem with Apple validation - so post GitHub release - then a patch release has to be made.

@BPerlakiH
Copy link
Collaborator

I've updated the readme and the CD workflow to reflect the above requirements.

@BPerlakiH BPerlakiH linked a pull request Oct 17, 2024 that will close this issue
@BPerlakiH BPerlakiH linked a pull request Oct 17, 2024 that will close this issue
@kelson42 kelson42 self-assigned this Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants