Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Functional tests fail for PHP 8+ #1331

Closed
thomaslow opened this issue Sep 11, 2024 · 0 comments · Fixed by #1332
Closed

[BUG] Functional tests fail for PHP 8+ #1331

thomaslow opened this issue Sep 11, 2024 · 0 comments · Fixed by #1332

Comments

@thomaslow
Copy link
Contributor

Description

Functional tests fail for PHP 8.x (tested with 8.1).

Reproduction

Steps to reproduce the behaviour:

  1. Run functional tests with PHP 8.1

Expected Behavior

Functional tests pass for PHP 8.x

Screenshots and Examples

Log of functional tests with PHP 8.1:

There was 1 error:

1) Kitodo\Dlf\Tests\Functional\Common\SolrIndexingTest::canIndexAndSearchDocument
TypeError: array_key_exists(): Argument #2 ($array) must be of type array, null given

/var/www/html/kitodo-presentation/Classes/Common/Solr/SolrSearch.php:863
/var/www/html/kitodo-presentation/Classes/Common/Solr/SolrSearch.php:514
/var/www/html/kitodo-presentation/Classes/Common/Solr/SolrSearchQuery.php:75
/var/www/html/kitodo-presentation/Tests/Functional/Common/SolrIndexingTest.php:92

--

There was 1 failure:

1) Kitodo\Dlf\Tests\Functional\Api\OaiPmhTest::noRecordsUntil1900
Failed asserting that exception of type "Phpoaipmh\Exception\MalformedResponseException" matches expected exception "Phpoaipmh\Exception\OaipmhException". Message was: "Could not decode XML Response: String could not be parsed as XML" at
/var/www/html/kitodo-presentation/vendor/caseyamcl/phpoaipmh/src/Client.php:134
/var/www/html/kitodo-presentation/vendor/caseyamcl/phpoaipmh/src/Client.php:95
/var/www/html/kitodo-presentation/vendor/caseyamcl/phpoaipmh/src/RecordIterator.php:224
/var/www/html/kitodo-presentation/vendor/caseyamcl/phpoaipmh/src/RecordIterator.php:190
/var/www/html/kitodo-presentation/vendor/caseyamcl/phpoaipmh/src/RecordIterator.php:326
/var/www/html/kitodo-presentation/Tests/Functional/Api/OaiPmhTest.php:179
.

Environment

  • OS version: Linux Docker (docker.io/php8.1-apache)
  • RDBMS version: docker.io/library/mariadb:10.11
  • Apache Solr version: 9.6
  • TYPO3 version: 11.5.39
  • PHP version: 8.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[BUG] Fix functional tests for PHP 8+ thomaslow/kitodo-presentation
1 participant
@thomaslow