[BUGFIX] Fix for $documentArray being null after function getDocumentById is called (#1345)

beatrycze-volk · sebastian-meyer · sebastian-meyer · commit fdc2975575af · 2024-10-10T11:58:15.000+02:00
Co-authored-by: Sebastian Meyer &lt;sebastian.meyer@opencultureconsulting.com&gt;
diff --git a/Classes/Controller/AbstractController.php b/Classes/Controller/AbstractController.php
@@ -508,11 +508,14 @@ protected function buildSimplePagination(PaginationInterface $pagination, Pagina
      */
     private function getDocumentByUid(int $documentId)
     {
+        // TODO: implement multiView as it is in getDocumentByUrl
         $doc = null;
         $this->document = $this->documentRepository->findOneByIdAndSettings($documentId);
 
         if ($this->document) {
             $doc = AbstractDocument::getInstance($this->document->getLocation(), $this->settings, true);
+            // fix for count(): Argument #1 ($value) must be of type Countable|array, null given
+            $this->documentArray[] = $doc;
         } else {
             $this->logger->error('Invalid UID "' . $documentId . '" or PID "' . $this->settings['storagePid'] . '" for document loading');
         }

Original file line number	Diff line number	Diff line change
`@@ -508,11 +508,14 @@ protected function buildSimplePagination(PaginationInterface $pagination, Pagina`
`508`	`508`	`*/`
`509`	`509`	`private function getDocumentByUid(int $documentId)`
`510`	`510`	`{`
	`511`	`+ // TODO: implement multiView as it is in getDocumentByUrl`
`511`	`512`	`$doc = null;`
`512`	`513`	`$this->document = $this->documentRepository->findOneByIdAndSettings($documentId);`
`513`	`514`
`514`	`515`	`if ($this->document) {`
`515`	`516`	`$doc = AbstractDocument::getInstance($this->document->getLocation(), $this->settings, true);`
	`517`	`+ // fix for count(): Argument #1 ($value) must be of type Countable\|array, null given`
	`518`	`+ $this->documentArray[] = $doc;`
`516`	`519`	`} else {`
`517`	`520`	`$this->logger->error('Invalid UID "' . $documentId . '" or PID "' . $this->settings['storagePid'] . '" for document loading');`
`518`	`521`	`}`