Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show aspect ratio and width/height on hover for images #19

Open
tisto opened this issue Apr 6, 2024 · 4 comments
Open

Show aspect ratio and width/height on hover for images #19

tisto opened this issue Apr 6, 2024 · 4 comments

Comments

@tisto
Copy link
Member

tisto commented Apr 6, 2024

For DLR we build the feature to show the aspect ratio of an image and the width and height on hover:

Screenshot_2024-04-04_at_12 45 46_PM

This would be a nice addition for kitconcept.intranet. However, this is something I'd like to have in all our kitconcept projects. Options:

a) implement in core (some things might be too opinionated, like a fixed set of aspect ratios)
b) implement in VLT? kitconcept-volto frontend package?

cc. @sneridagh @ericof @davisagli @robgietema

@davisagli
Copy link
Member

davisagli commented Apr 8, 2024

a) implement in core (some things might be too opinionated, like a fixed set of aspect ratios)

I wouldn't be too worried about this. It's an informational feature for editors, and it's easy enough to make it configurable with a setting instead of fixed.

@tisto
Copy link
Member Author

tisto commented Apr 16, 2024

@davisagli is this a feature that you could imagine to work on with us for the Plone Distribution idea in general? @steffenri and I would like to work on the kitconcept.intranet distribution this week. You could work on the edu distribution and we could use the same enhancements together and try them out. What do you think?

Other topics could be the "kicker" behavior (#17) and the preview_image_link (#16) behavior.

cc @sneridagh @danalvrz @ericof

@davisagli
Copy link
Member

@tisto This one sounds like it should be a core Volto feature to me. It's useful to any editor, not just for a specific distribution.

As it turns out, for the sprint I am focusing first on some fixes for the Plone cookiecutter. I might be able to work on some of those tickets for the edu distribution later in the week, but I can do them on my own at any time, so I'll prioritize topics that require discussions with the people at the sprint.

@tisto
Copy link
Member Author

tisto commented Apr 16, 2024

@davisagli I couldn't agree more. This is why I am bringing this up. kicker, preview_image_link and image enhancements should go into core. Our problem right now is just that this kind of blocks my efforts to work on example content. If I don't have the basics right, it does not make sense to work on example content. Especially when I upload images and they stay in the repo forever.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants