Skip to content
This repository has been archived by the owner on Oct 24, 2020. It is now read-only.

Use GitHub Releases #27

Open
schu opened this issue Aug 16, 2017 · 3 comments
Open

Use GitHub Releases #27

schu opened this issue Aug 16, 2017 · 3 comments
Assignees

Comments

@schu
Copy link
Contributor

schu commented Aug 16, 2017

Currently we rely on CircleCI assets for stage1-builder images:

<meta name="ac-discovery" content="kinvolk.io/aci/rkt/stage1-kvm-beta https://circleci.com/api/v1/project/kinvolk/stage1-builder/latest/artifacts/0/$CIRCLE_ARTIFACTS/stage1-kvm-{version}-linux-{kernelversion}.{ext}?filter=successful">
<meta name="ac-discovery" content="kinvolk.io/aci/rkt/stage1-kvm https://circleci.com/api/v1/project/kinvolk/stage1-builder/latest/artifacts/0/$CIRCLE_ARTIFACTS/stage1-kvm-{version}-linux-{kernelversion}.{ext}?filter=successful&branch=master">

This is brittle (images can change unexpectedly with newer stage1-builder versions; old images have to be rebuild on every stage1-builder update, as we point to latest artifacts; etc)

Instead, try to use GitHub Releases: https://help.github.com/articles/creating-releases/

@schu schu self-assigned this Aug 16, 2017
@alban
Copy link
Contributor

alban commented Aug 16, 2017

I agree. See also #26 (comment)

@alban
Copy link
Contributor

alban commented Aug 16, 2017

Ideally we need to be able to both use release artifacts and artifacts from a specific build on a branch, in order to test changes in stage1-builder.

@lmb
Copy link
Contributor

lmb commented May 9, 2018

FWIW https://jedkirby.com/blog/github-releases-with-circleci has a tutorial for this. Maybe that is enough?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants