Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

setting Notch value can result in one side with incorrect tab width #6

Open
michaelhauser opened this issue Oct 20, 2016 · 7 comments
Open

setting Notch value can result in one side with incorrect tab width #6

michaelhauser opened this issue Oct 20, 2016 · 7 comments
Assignees
@kigster
Labels
bug
Milestone
V2

Comments

@michaelhauser
Copy link

Setting Notch value sometimes results in one side with incorrect tab width. An example is attached.

makeabox-io-18.5x12.25x1.5-4183.box.pdf
@kigster
Copy link
Owner

kigster commented Oct 21, 2016

What do you mean incorrect?

It's not meant to be exact, as the algorithm must break each side in equividistant sections.

What did you expect to see, and what did you get exactly?

@michaelhauser
Copy link
Author

The two long side panels are different and the one at the bottom of the PDF has slots that are too big for the tabs on the short side panels. Or am I missing something?

@kigster
Copy link
Owner

kigster commented Jan 16, 2017

Yes, thank you — bug confirmed with another set of values: 5.5x2.0x6.0, notch 0.375, kerf 0.008.

@kigster kigster self-assigned this Jan 16, 2017
@kigster kigster added the bug label Jan 16, 2017
@kigster kigster mentioned this issue May 7, 2017
Closed
@kigster
Copy link
Owner

kigster commented May 28, 2017 •
edited
Loading

Some dimensions that generated the invalid printout:

laser-cutter-issue-7-dimensions

makeabox-io-18_5x12_25x1_5-4183_box-details

@kigster kigster added this to the V2 milestone May 28, 2017
@kigster kigster mentioned this issue May 28, 2017
Open
@kigster
Copy link
Owner

kigster commented May 28, 2017

Damn this bug :)

@hellocatfood
Copy link

Another set of values that causes an incomplete box
screenshot from 2017-07-14 17-57-22
makeabox-90.00W-90.00H-90.00D-3.00T-20170714165535.pdf

@kigster kigster mentioned this issue Dec 5, 2017
Closed
kigster added a commit that referenced this issue Jan 1, 2018
@kigster
Adjust for kerf after computing notch width.
e75e332 
 - hopefully fixes issue #3
   #6
@kigster
Copy link
Owner

kigster commented Jan 1, 2018

OK I think this is now fixed in version 1.0.5. Please test and report back. Thanks!

@kigster kigster closed this as completed Jan 1, 2018
@kigster kigster reopened this Sep 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kigster kigster

Labels
bug
Projects
None yet
Milestone
V2
Development

No branches or pull requests
3 participants
@hellocatfood @kigster @michaelhauser