Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crash when viewing Jewelry writ if Summerset DLC is not enabled #7

Open
kierdavis opened this issue Mar 16, 2021 · 0 comments
Open

Crash when viewing Jewelry writ if Summerset DLC is not enabled #7

kierdavis opened this issue Mar 16, 2021 · 0 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@kierdavis
Copy link
Owner

I haven't encountered this in practice but I think this will happen:

When viewing a Jewelry writ, extendTooltip will call EqRecipe:fromWritText, which will fail because (as of e9cd940) jewelry recipes are not listed in EqRecipe.instancesByName.

This could be fixed by only registering the jewelry Skill instance if the DLC is enabled. Behaviour to gracefully handle a writ not matching any registered Skill instance already exists (it takes effect for holiday/imperial furniture writs).
@kierdavis kierdavis added bug Something isn't working good first issue Good for newcomers labels Mar 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kierdavis