Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SlackSender 리팩토링 #61

Open
1 of 5 tasks
Coalery opened this issue Sep 16, 2024 · 1 comment
Open
1 of 5 tasks

SlackSender 리팩토링 #61

Coalery opened this issue Sep 16, 2024 · 1 comment
Assignees
Labels
refactoring Refactor code request

Comments

@Coalery
Copy link
Member

Coalery commented Sep 16, 2024

  • core 디렉터리로 옮기
  • SlackSender 대신 MessageSender 이름으로 수정
  • MessageBuilderMessageSender 내로 옮겨오기
  • MessageSender@send의 페이로드를 어떤 abstract class로 받도록 구현 (이름은 미정)
  • 위 추상 클래스의 구현체로 슬랙 메시지 클래스 구현 (category, message 등을 프로퍼티로 갖고 있음)
@Coalery Coalery self-assigned this Sep 16, 2024
@Coalery Coalery added the refactoring Refactor code request label Sep 16, 2024
@Coalery
Copy link
Member Author

Coalery commented Sep 17, 2024

MessageBuilder는 별도 의존성이 없고 util 성격의 클래스기 때문에 static method로 수정함.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Refactor code request
Projects
None yet
Development

No branches or pull requests

1 participant