Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The tool has too many dependenies #19

Open
KOLANICH opened this issue Jun 8, 2018 · 2 comments
Open

The tool has too many dependenies #19

KOLANICH opened this issue Jun 8, 2018 · 2 comments

Comments

@KOLANICH
Copy link

KOLANICH commented Jun 8, 2018

I guess we need to make most of the dependencies optional.

@kewisch
Copy link
Owner

kewisch commented Jun 8, 2018

I'm fine with making some of them optional, but if you happen to work on a patch for this lets discuss which ones first. I'd like to find a balance between making the code more complicated to read and including all the things.

@KOLANICH
Copy link
Author

KOLANICH commented Jun 9, 2018

It may worth to separate the logic from API wrapper. I mean to create a separate module containing only API (and scraper for the things unavailable via API) and hard-dependent only on requests. Some soft dependencies may be needed for authentication purposes).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants