Skip to content

Commit 5d3772f

Browse files
committed
Rename tableStorageFormat in HiveInsertTableHandle
Each partition can have its own storage format, the format info in HiveInsertTableHandle is not necessarily table format
1 parent c3023b6 commit 5d3772f

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

velox/connectors/hive/HiveDataSink.h

+5-5
Original file line numberDiff line numberDiff line change
@@ -201,7 +201,7 @@ class HiveInsertTableHandle : public ConnectorInsertTableHandle {
201201
HiveInsertTableHandle(
202202
std::vector<std::shared_ptr<const HiveColumnHandle>> inputColumns,
203203
std::shared_ptr<const LocationHandle> locationHandle,
204-
dwio::common::FileFormat tableStorageFormat =
204+
dwio::common::FileFormat storageFormat =
205205
dwio::common::FileFormat::DWRF,
206206
std::shared_ptr<const HiveBucketProperty> bucketProperty = nullptr,
207207
std::optional<common::CompressionKind> compressionKind = {},
@@ -210,7 +210,7 @@ class HiveInsertTableHandle : public ConnectorInsertTableHandle {
210210
nullptr)
211211
: inputColumns_(std::move(inputColumns)),
212212
locationHandle_(std::move(locationHandle)),
213-
tableStorageFormat_(tableStorageFormat),
213+
storageFormat_(storageFormat),
214214
bucketProperty_(std::move(bucketProperty)),
215215
compressionKind_(compressionKind),
216216
serdeParameters_(serdeParameters),
@@ -237,8 +237,8 @@ class HiveInsertTableHandle : public ConnectorInsertTableHandle {
237237
return compressionKind_;
238238
}
239239

240-
dwio::common::FileFormat tableStorageFormat() const {
241-
return tableStorageFormat_;
240+
dwio::common::FileFormat storageFormat() const {
241+
return storageFormat_;
242242
}
243243

244244
const std::unordered_map<std::string, std::string>& serdeParameters() const {
@@ -272,7 +272,7 @@ class HiveInsertTableHandle : public ConnectorInsertTableHandle {
272272
private:
273273
const std::vector<std::shared_ptr<const HiveColumnHandle>> inputColumns_;
274274
const std::shared_ptr<const LocationHandle> locationHandle_;
275-
const dwio::common::FileFormat tableStorageFormat_;
275+
const dwio::common::FileFormat storageFormat_;
276276
const std::shared_ptr<const HiveBucketProperty> bucketProperty_;
277277
const std::optional<common::CompressionKind> compressionKind_;
278278
const std::unordered_map<std::string, std::string> serdeParameters_;

0 commit comments

Comments
 (0)