Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify bin creation #31

Open
sindresorhus opened this issue Dec 15, 2014 · 3 comments · May be fixed by #34
Open

Simplify bin creation #31

sindresorhus opened this issue Dec 15, 2014 · 3 comments · May be fixed by #34
Labels
enhancement question

Comments

@sindresorhus
Copy link
Contributor

Currently we manually have to create useless proxies like these: https://github.com/kevva/elm-platform-bin/tree/master/bin

The reason is that we have to define the path to the binary in package.json up front.

Another way we could do it is to instead have bin-wrapper copy/move the binary to a fixed path/name we define in package.json.

@kevva What do you think?
@kevva
Copy link
Owner

kevva commented Dec 30, 2014

So instead of defining .dest() it could check for bin in the package.json and use that path? Sounds good to me.

@sindresorhus
Copy link
Contributor Author

Yup.

@kevva
Copy link
Owner

kevva commented Dec 30, 2014

It has to match the one defined in .use() though if you were to create multiple binaries like we do in elm-platform. In other words, the binary name must be the same as the bin in package.json.

kevva added a commit that referenced this issue Dec 30, 2014
@kevva
Use binary destination set in package.json
3d26d5a 
Fixes #31.
kevva added a commit that referenced this issue Dec 30, 2014
@kevva
Use binary destination set in package.json
59a012e 
Fixes #31.
@kevva kevva linked a pull request Dec 30, 2014 that will close this issue
Open
@kevva kevva mentioned this issue Jan 8, 2016
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement question
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use binary destination set in package.json kevva/bin-wrapper
2 participants
@sindresorhus @kevva