Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URL Submission not properly handling commas #2218

Open
6 tasks done
CarsonHrusovsky opened this issue Jul 10, 2024 · 7 comments
Open
6 tasks done

URL Submission not properly handling commas #2218

CarsonHrusovsky opened this issue Jul 10, 2024 · 7 comments

Comments

@CarsonHrusovsky
Copy link
Contributor

About accounts on capesandbox.com

  • Issues isn't the way to ask for account activation. Ping capesandbox in Twitter with your username

This is open source and you are getting free support so be friendly!

Prerequisites

Please answer the following questions for yourself before submitting an issue.

  • I am running the latest version
  • I did read the README!
  • I checked the documentation and found no answer
  • I checked to make sure that this issue has not already been filed
  • I'm reporting the issue to the correct repository (for multi-repository projects)
  • I have read and checked all configs (with all optional parts)

Issue

This is a pretty simple bug. When submitting URLs for analysis, if a url contains a comma it interprets it as two separate submissions. This may be by design for allowing multiple submissions from the same command, but it doesn't work particularly well in a production environment.

image

image

I'd recommend just handling input on submission as a string.

Question Answer
Git commit commit 97eeb1c
OS version Ubuntu 24.04
@doomedraven
Copy link
Collaborator

it does, it says URL, not urlS, you need to wrie extension to handly multiple urls

@CarsonHrusovsky
Copy link
Contributor Author

So this isn't intended behavior? We have seen legitimate url submissions that contain a comma character in them, but is interpreted as two separate submissions.

@doomedraven
Copy link
Collaborator

Idk, I never submitted more that one so can't speak of that

@doomedraven
Copy link
Collaborator

ok now that i read your issue properly, yes we do split by comma in urls to split them by comma, not sure which char to use to split them properly as i see that yes that allows to use comma, any suggestion? sorry misread your issue initially

@CarsonHrusovsky
Copy link
Contributor Author

no worries - can be tricky to find a good delimiting character. I'd suggest something that can't appear in normal URL, so say a space maybe? If that doesn't work for other user use case, maybe a better solution is to make multi submissions a toggle in the web GUI.

Otherwise I'd use a Latin-American character but I've no idea how this would impact other users who aren't using our character set.

@doomedraven
Copy link
Collaborator

doomedraven commented Jul 23, 2024 via email

@CarsonHrusovsky
Copy link
Contributor Author

hmm okay - maybe this a feature that isn't needed? Would be very easy to automate multiple submissions for users who need that - and by default just make only one submission at a time expected?

I struggle to think of a character that a user would both expect to be a separator and also have regular access to. (␛) this character for example could be used but this isn't practical.

I think the best choice is to have users who want to submit multiple URL at the same time to handle that in a script (and have a toggle in the GUI for them as well). I would be more than happy to write a script to submit multiple URL that can be kept in the /extra/ directory for manual use by users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants