Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep unstructured annotation for manually defining a root_key #28

Open
maximilian-heeg opened this issue Dec 1, 2020 · 2 comments
Open

Comments

@maximilian-heeg
Copy link

Hi,

thanks for that wonderful package. I have encountered a issue with one dataset where I wanted to manually define the starting cell of the latent time.

The python package allows to specify a root_key and end_key for the calculation of the pseudotime and latent time.
https://scvelo.readthedocs.io/scvelo.tl.latent_time.html#scvelo.tl.latent_time

The root_key is stored in the unstructured annotation of the adata object. See also here: https://github.com/theislab/scvelo/blob/master/scvelo/tools/dynamical_model.py#L758-L766

Currently, the adata object in this package is created from scratch.
adata <- and$AnnData(X, layers=list(spliced=spliced, unspliced=unspliced))
https://github.com/kevinrue/velociraptor/blob/master/R/scvelo.R#L191

Therefore it is currently not possible to store any information in the unstructured annotation. Could the metadata of a sce object be potentially converted to the unstructured annotation?

Thanks you very much for your help!
Max

@kevinrue
Copy link
Owner

kevinrue commented Dec 1, 2020

Hi Max

Thank you for the kind words.

Indeed that sounds entirely feasible, simply an overlook at this stage.

We'll look into it for the next version shortly and get back to you.

Thank you for the feedback!
Kevin

@LTLA
Copy link
Collaborator

LTLA commented Dec 1, 2020

Sounds like we should be using zellkonverter's conversion utilities to handle the AnnData construction for us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants