Smb: Download does not work if filename contains spaces/special chars and at least two dots

[filip-paczynski]

Describe the issue

For a file stored on a SMB or SFTP server server at path /share/some dir/file name with spaces .and some dots.txt

- id: download
  type: io.kestra.plugin.fs.smb.Download
  host: "server"
  username: "login"
  password: "password"
  from: "/share/some dir/file name with spaces .and some dots.txt"

An exception is thrown:

java.lang.IllegalArgumentException: Illegal character in path at index [SOMEIDX]: [REDACTED[/namespace/SOMEID.and some dots.txt
        at java.base/java.net.URI.create(URI.java:932)
        at java.base/java.net.URI.resolve(URI.java:1122)
        at io.kestra.core.storages.InternalStorage.putFile(InternalStorage.java:179)
        at io.kestra.core.storages.InternalStorage.putFile(InternalStorage.java:170)
        at io.kestra.plugin.fs.vfs.VfsService.download(VfsService.java:140)
        at io.kestra.plugin.fs.vfs.Download.run(Download.java:31)
        at io.kestra.plugin.fs.vfs.Download.run(Download.java:14)
        at io.kestra.core.runners.WorkerTaskCallable.doCall(WorkerTaskCallable.java:78)
        at io.kestra.core.runners.AbstractWorkerCallable.call(AbstractWorkerCallable.java:56)
        at io.kestra.core.runners.WorkerSecurityService.callInSecurityContext(WorkerSecurityService.java:10)
        at io.kestra.core.runners.Worker.callJob(Worker.java:779)
        at io.kestra.core.runners.Worker.runAttempt(Worker.java:738)
        at io.kestra.core.runners.Worker.run(Worker.java:589)
        at io.kestra.core.runners.Worker.handleTask(Worker.java:294)
        at io.kestra.core.runners.Worker.lambda$run$8(Worker.java:250)
        at io.micrometer.core.instrument.internal.TimedRunnable.run(TimedRunnable.java:49)
        at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1144)
        at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:642)
        at java.base/java.lang.Thread.run(Thread.java:1583)
Caused by: java.net.URISyntaxException: Illegal character in path at index 149: /promonotes/nexo/auto_attach/tes>
        at java.base/java.net.URI$Parser.fail(URI.java:2995)
        at java.base/java.net.URI$Parser.checkChars(URI.java:3166)
        at java.base/java.net.URI$Parser.parseHierarchical(URI.java:3248)
        at java.base/java.net.URI$Parser.parse(URI.java:3207)
        at java.base/java.net.URI.<init>(URI.java:645)
        at java.base/java.net.URI.create(URI.java:930)

I guess that it tries to use extension in internal kestra storage, but stops at first . instead of the last.

EDIT: I thought this only occurs with SMB, but after trying SFTP - it also failed in the same way

Environment

• Kestra Version: 0.20.11
• fs-plugin version: 0.20.0

config.yml:

kestra:
  storage:
    type: local
    local:
      base-path: /mnt/storage-kestra